From 326d1513a4b68aaf29a702aec1d8fefed130d936 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 29 Oct 2015 14:51:37 +0000 Subject: [PATCH] Bug 15084: Remove C4::Budgets::ConvertCurrency This subroutine is unused and can be removed. There is no trace left of currency in C4::Budgets. --- C4/Budgets.pm | 33 --------------------------------- acqui/basketgroup.pl | 1 - 2 files changed, 34 deletions(-) diff --git a/C4/Budgets.pm b/C4/Budgets.pm index 5cd5860..93710f6 100644 --- a/C4/Budgets.pm +++ b/C4/Budgets.pm @@ -59,8 +59,6 @@ BEGIN { &ModBudgetPlan - &ConvertCurrency - &GetBudgetsPlanCell &AddBudgetPlanValue &GetBudgetAuthCats @@ -913,37 +911,6 @@ sub CanUserModifyBudget { return 1; } -# ------------------------------------------------------------------- - -=head2 ConvertCurrency - - $foreignprice = &ConvertCurrency($currency, $localprice); - -Converts the price C<$localprice> to foreign currency C<$currency> by -dividing by the exchange rate, and returns the result. - -If no exchange rate is found, e is one to one. - -=cut - -sub ConvertCurrency { - my ( $currency, $price ) = @_; - my $dbh = C4::Context->dbh; - my $query = " - SELECT rate - FROM currency - WHERE currency=? - "; - my $sth = $dbh->prepare($query); - $sth->execute($currency); - my $cur = ( $sth->fetchrow_array() )[0]; - unless ($cur) { - $cur = 1; - } - return ( $price / $cur ); -} - - =head2 CloneBudgetPeriod my $new_budget_period_id = CloneBudgetPeriod({ diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl index b2ed7db..dacc74e 100755 --- a/acqui/basketgroup.pl +++ b/acqui/basketgroup.pl @@ -51,7 +51,6 @@ use C4::Auth; use C4::Output; use CGI qw ( -utf8 ); -use C4::Budgets qw/ConvertCurrency/; use C4::Acquisition qw/CloseBasketgroup ReOpenBasketgroup GetOrders GetBasketsByBasketgroup GetBasketsByBookseller ModBasketgroup NewBasketgroup DelBasketgroup GetBasketgroups ModBasket GetBasketgroup GetBasket GetBasketGroupAsCSV/; use C4::Branch qw/GetBranches/; use C4::Members qw/GetMember/; -- 2.1.0