Bugzilla – Attachment 4585 Details for
Bug 5511
Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently.
Check-for-Change-in-Remote-IP-address-for-Session-.patch (text/plain), 5.47 KB, created by
Chris Cormack
on 2011-07-07 23:31:38 UTC
(
hide
)
Description:
Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently.
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2011-07-07 23:31:38 UTC
Size:
5.47 KB
patch
obsolete
>From 0b6bc9d34ea08c4eac5768fc3b773745ed62309a Mon Sep 17 00:00:00 2001 >From: Amit Gupta <amit.gupta@osslabs.biz> >Date: Thu, 16 Dec 2010 15:52:50 +0530 >Subject: [PATCH] Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. > >http://bugs.koha-community.org/show_bug.cgi?id=5511 >--- > C4/Auth.pm | 5 +++-- > installer/data/mysql/en/mandatory/sysprefs.sql | 1 + > installer/data/mysql/updatedatabase.pl | 10 ++++++++++ > .../prog/en/modules/admin/preferences/admin.pref | 9 ++++++++- > 4 files changed, 22 insertions(+), 3 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index b6ec69a..eaf6145 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -947,6 +947,7 @@ sub checkauth { > login => 1, > INPUTS => \@inputs, > casAuthentication => C4::Context->preference("casAuthentication"), >+ remoteipcheck => C4::Context->preference("remoteipcheck"), > suggestion => C4::Context->preference("suggestion"), > virtualshelves => C4::Context->preference("virtualshelves"), > LibraryName => C4::Context->preference("LibraryName"), >@@ -1098,7 +1099,7 @@ sub check_api_auth { > $userid = undef; > $sessionID = undef; > return ("expired", undef, undef); >- } elsif ( $ip ne $ENV{'REMOTE_ADDR'} ) { >+ } elsif ( C4::Context->preference('remoteipcheck') && $ip ne $ENV{'REMOTE_ADDR'} ) { > # IP address changed > $session->delete(); > C4::Context->_unset_userenv($sessionID); >@@ -1324,7 +1325,7 @@ sub check_cookie_auth { > $userid = undef; > $sessionID = undef; > return ("expired", undef); >- } elsif ( $ip ne $ENV{'REMOTE_ADDR'} ) { >+ } elsif ( C4::Context->preference('remoteipcheck') && $ip ne $ENV{'REMOTE_ADDR'} ) { > # IP address changed > $session->delete(); > C4::Context->_unset_userenv($sessionID); >diff --git a/installer/data/mysql/en/mandatory/sysprefs.sql b/installer/data/mysql/en/mandatory/sysprefs.sql >index 0abf9d8..4c98249 100755 >--- a/installer/data/mysql/en/mandatory/sysprefs.sql >+++ b/installer/data/mysql/en/mandatory/sysprefs.sql >@@ -314,3 +314,4 @@ INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES > INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('OpacHiddenItems','','This syspref allows to define custom rules for hiding specific items at opac. See docs/opac/OpacHiddenItems.txt for more informations.','','Textarea'); > INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('numSearchRSSResults',50,'Specify the maximum number of results to display on a RSS page of results',NULL,'Integer'); > INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('OpacRenewalBranch','checkoutbranch','Choose how the branch for an OPAC renewal is recorded in statistics','itemhomebranch|patronhomebranch|checkoutbranch|null','Choice'); >+INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('remoteipcheck','0','Check for Change in Remote IP address for Session Security . Disable when remote ip address changes frequently.','','YesNo'); >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 8fb9656..87ea1ef 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -4251,6 +4251,7 @@ $DBversion = '3.03.00.044'; > if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { > $dbh->do("ALTER TABLE `aqbasketgroups` ADD `freedeliveryplace` TEXT NULL AFTER `deliveryplace`;"); > print "Upgrade to $DBversion done (adding freedeliveryplace to basketgroups)\n"; >+ SetVersion ($DBversion); > } > > $DBversion = '3.03.00.045'; >@@ -4370,6 +4371,15 @@ if (C4::Context->preference("Version") < TransformToNum($DBversion)) { > SetVersion($DBversion); > } > >+$DBversion = '3.05.00.XXX'; >+if (C4::Context->preference("Version") < TransformToNum($DBversion)) { >+ $dbh->do("INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('remoteipcheck','0','Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently.','','YesNo')"); >+ print "Upgrade to $DBversion done adding syspref Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently."; >+ SetVersion ($DBversion); >+} >+ >+ >+ > =head1 FUNCTIONS > > =head2 DropAllForeignKeys($table) >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref >index a2ecc5c..eb0b45e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref >@@ -41,7 +41,14 @@ Administration: > no: "Don't allow" > - staff and patrons to create and view saved lists of books. > Login options: >- - >+ - >+ - pref: remoteipcheck >+ default: 0 >+ choices: >+ yes: Enable >+ no: "Disable" >+ - Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. >+ - > - pref: insecure > default: 0 > choices: >-- >1.7.4.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5511
:
2860
|
4585
|
4586
|
21864
|
21865
|
22533
|
34216
|
34218
|
34219
|
34252
|
34320
|
34616
|
34709
|
34710
|
34711
|
34712
|
34713
|
34824