Bugzilla – Attachment 4593 Details for
Bug 6076
acqui pdf error when marcxml wrong
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
0001-PATCH-BZ7076-acqui-pdf-error-when-marcxml-wrong.patch (text/plain), 1.66 KB, created by
Jonathan Druart
on 2011-07-08 09:19:26 UTC
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2011-07-08 09:19:26 UTC
Size:
1.66 KB
patch
obsolete
>From 1899e70f6424c6b0b6c1b9585c270ae647b5465e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 8 Jul 2011 11:13:41 +0200 >Subject: [PATCH] [PATCH] BZ7076: acqui pdf error when marcxml wrong > >when marcxml is wrong the PDF is not generated. There is a Perl error >because >the biblio can't be retrieved. >This can be workarounded with a eval when decoding the marc >--- > acqui/basketgroup.pl | 11 +++++++---- > 1 files changed, 7 insertions(+), 4 deletions(-) > >diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl >index 457b616..0211c24 100755 >--- a/acqui/basketgroup.pl >+++ b/acqui/basketgroup.pl >@@ -226,10 +226,13 @@ sub printbasketgrouppdf{ > push(@ba_orders, \@ba_order); > # Editor Number > my $en; >- if (C4::Context->preference("marcflavour") eq 'UNIMARC') { >- $en = MARC::Record::new_from_xml($ord->{marcxml},'UTF-8')->subfield('345',"b"); >- } elsif (C4::Context->preference("marcflavour") eq 'MARC21') { >- $en = MARC::Record::new_from_xml($ord->{marcxml},'UTF-8')->subfield('037',"a"); >+ my $marcrecord=eval{MARC::Record::new_from_xml( $ord->{marcxml},'UTF-8' )}; >+ if ($marcrecord){ >+ if ( C4::Context->preference("marcflavour") eq 'UNIMARC' ) { >+ $en = $marcrecord->subfield( '345', "b" ); >+ } elsif ( C4::Context->preference("marcflavour") eq 'MARC21' ) { >+ $en = $marcrecord->subfield( '037', "a" ); >+ } > } > if($en){ > push(@ba_order, $en); >-- >1.7.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6076
:
3718
| 4593