From ad03e87abe0bd9ac28af37068ed42e43b87233a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc=20V=C3=A9ron?= Date: Sat, 26 Dec 2015 12:28:57 +0100 Subject: [PATCH] Bug 1983: Checkout: Hold request when checking out an item already on loan or reserved This patch allows to put a hold on an item that is already checked out or reserved. To test: - Check out an item A - Put a hold on an item B - Verify thath the staff user has permission to put holds - Check out item A to a patron X - Try to checkout item A to a patron Y - Verify that you see near the buttons for Checkin/Checkout a link "Click here to place hold" - Verify that the link is stylable (span class circ-scheckoutplacehold) - Verify that the link takes you to the page for placing holds as appropriate - Do the same for item B and verify that it works for reserved items as well. - Log in with a staff client who has no permission to place holds - Repeat steps above, verify that the link does not appear. --- circ/circulation.pl | 9 +++++++-- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 5 +++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index 3748d97..e00cbec 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -422,11 +422,16 @@ if (@$barcodes) { if ($question->{RESERVE_WAITING} or $question->{RESERVED}){ $template->param( - reserveborrowernumber => $question->{'resborrowernumber'}, - itembiblionumber => $getmessageiteminfo->{'biblionumber'} + reserveborrowernumber => $question->{'resborrowernumber'} ); } + $template->param( + itembiblionumber => $getmessageiteminfo->{'biblionumber'} + ); + + + $template_params->{issuecount} = $issue; if ( $iteminfo ) { diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt index 19ba9fa..e8a1eb5 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ -407,6 +407,11 @@ $(document).ready(function() { [% END %] +[% IF ( RESERVE_WAITING ) || ( RESERVED ) || ( ISSUED_TO_ANOTHER ) %] + [%IF (CAN_user_reserveforothers_place_holds ) %] + Click here to place hold + [% END %] +[% END %] [% END %] -- 1.7.10.4