Bugzilla – Attachment 45991 Details for
Bug 1983
Add option to create hold request when checking out an item already on loan
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 1983: Checkout: Hold request when checking out an item already on loan or reserved
Bug-1983-Checkout-Hold-request-when-checking-out-a.patch (text/plain), 2.63 KB, created by
Chris Cormack
on 2015-12-27 02:51:27 UTC
(
hide
)
Description:
Bug 1983: Checkout: Hold request when checking out an item already on loan or reserved
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2015-12-27 02:51:27 UTC
Size:
2.63 KB
patch
obsolete
>From 42f6b635859f699b71296f1920758dcb1dbfbf4d Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Sat, 26 Dec 2015 12:28:57 +0100 >Subject: [PATCH] Bug 1983: Checkout: Hold request when checking out an item > already on loan or reserved > >This patch allows to put a hold on an item that is already checked out or reserved. > >To test: > >- Check out an item A >- Put a hold on an item B >- Verify thath the staff user has permission to put holds >- Check out item A to a patron X >- Try to checkout item A to a patron Y >- Verify that you see near the buttons for Checkin/Checkout a link "Click here to place hold" >- Verify that the link is stylable (span class circ-scheckoutplacehold) >- Verify that the link takes you to the page for placing holds as appropriate >- Do the same for item B and verify that it works for reserved items as well. >- Log in with a staff client who has no permission to place holds >- Repeat steps above, verify that the link does not appear. > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >--- > circ/circulation.pl | 9 +++++++-- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 5 +++++ > 2 files changed, 12 insertions(+), 2 deletions(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index 3748d97..e00cbec 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -422,11 +422,16 @@ if (@$barcodes) { > > if ($question->{RESERVE_WAITING} or $question->{RESERVED}){ > $template->param( >- reserveborrowernumber => $question->{'resborrowernumber'}, >- itembiblionumber => $getmessageiteminfo->{'biblionumber'} >+ reserveborrowernumber => $question->{'resborrowernumber'} > ); > } > >+ $template->param( >+ itembiblionumber => $getmessageiteminfo->{'biblionumber'} >+ ); >+ >+ >+ > $template_params->{issuecount} = $issue; > > if ( $iteminfo ) { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 19ba9fa..e8a1eb5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -407,6 +407,11 @@ $(document).ready(function() { > [% END %] > </form> > >+[% IF ( RESERVE_WAITING ) || ( RESERVED ) || ( ISSUED_TO_ANOTHER ) %] >+ [%IF (CAN_user_reserveforothers_place_holds ) %] >+ <span class="circ-checkoutplacehold"><a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% itembiblionumber %]&findborrower=x">Click here to place hold</a></span> >+ [% END %] >+[% END %] > </div></div> > [% END %] <!-- NEEDSCONFIRMATION --> > >-- >2.6.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 1983
:
45984
|
45991
|
46668
|
46758
|
46856