Bugzilla – Attachment 4614 Details for
Bug 6573
Library name entry field enforces unnecessary maxlength
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-Bug-6573-Library-name-entry-field-enforces-u.patch (text/plain), 5.19 KB, created by
Owen Leonard
on 2011-07-11 12:55:41 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-07-11 12:55:41 UTC
Size:
5.19 KB
patch
obsolete
>From c4cce2c2029fe58d6394506c975ecc4a0ad07ecd Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 11 Jul 2011 08:53:19 -0400 >Subject: [PATCH] Fix for Bug 6573 - Library name entry field enforces unnecessary maxlength >Content-Type: text/plain; charset="utf-8" > >Removing maxlength from branches.tt and other admin templates >which enforce it unnecessarily. Correcting other maxlengths >which do not match the database structure. >--- > .../prog/en/modules/admin/branches.tt | 8 ++++---- > .../intranet-tmpl/prog/en/modules/admin/cities.tt | 4 ++-- > .../prog/en/modules/admin/itemtypes.tt | 2 +- > .../prog/en/modules/admin/roadtype.tt | 2 +- > 4 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >index 0b1a914..b92ad52 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >@@ -91,7 +91,7 @@ > </li> > <li> > <label for="branchname">Name</label> >- <input type="text" name="branchname" id="branchname" size="40" maxlength="80" value="[% branch_name |html %]" /> >+ <input type="text" name="branchname" id="branchname" size="80" value="[% branch_name |html %]" /> > </li> > </ol> > </fieldset> >@@ -301,16 +301,16 @@ > [% categorycode %] > [% ELSE %] > <label for="categorycode">Category code:</label> >- <input type="text" name="categorycode" id="categorycode" size="11" maxlength="10" value="[% categorycode |html %]" /> >+ <input type="text" name="categorycode" id="categorycode" size="10" maxlength="10" value="[% categorycode |html %]" /> > [% END %] > </li> > <li> > <label for="categoryname">Name: </label> >- <input type="text" name="categoryname" id="categoryname" size="40" maxlength="80" value="[% categoryname |html %]" /> >+ <input type="text" name="categoryname" id="categoryname" size="32" maxlength="32" value="[% categoryname |html %]" /> > </li> > <li> > <label for="codedescription">Description: </label> >- <input type="text" name="codedescription" id="codedescription" size="70" maxlength="80" value="[% codedescription |html %]" /> >+ <input type="text" name="codedescription" id="codedescription" size="70" value="[% codedescription |html %]" /> > </li> > <li> > <label for="categorytype">Category Type: </label> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt >index dd25420..2e9bdd2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt >@@ -63,11 +63,11 @@ > [% END %] > <li> > <label for="city_name">City, State: </label> >- <input type="text" name="city_name" id="city_name" size="40" maxlength="80" value="[% city_name |html %]" /> >+ <input type="text" name="city_name" id="city_name" size="80" maxlength="100" value="[% city_name |html %]" /> > </li> > <li> > <label for="city_zipcode">Zip/Postal code: </label> >- <input type="text" name="city_zipcode" id="city_zipcode" size="10" maxlength="10" value="[% city_zipcode %]" /> >+ <input type="text" name="city_zipcode" id="city_zipcode" size="20" maxlength="20" value="[% city_zipcode %]" /> > </li></ol></fieldset> > > <fieldset class="action"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt >index 8ce9744..9174247 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt >@@ -171,7 +171,7 @@ Item Types Administration > </li> > [% END %] > <li> >- <label for="description">Description</label><input type="text" id="description" name="description" size="48" maxlength="80" value="[% description |html %]" /> </li> >+ <label for="description">Description</label><input type="text" id="description" name="description" size="48" value="[% description |html %]" /> </li> > [% IF ( noItemTypeImages ) %] > <li><span class="label">Image: </span>Item type images are disabled. To enable them, turn off the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=noItemTypeImages">noItemTypeImages system preference</a></li></ol> > [% ELSE %]</ol> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/roadtype.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/roadtype.tt >index b0bad31..2e6e8a1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/roadtype.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/roadtype.tt >@@ -81,7 +81,7 @@ > [% END %] > <li> > <label for="road_type">Road type: </label> >- <input type="text" name="road_type" id="road_type" size="40" maxlength="80" value="[% road_type |html %]" /> >+ <input type="text" name="road_type" id="road_type" size="80" maxlength="100" value="[% road_type |html %]" /> > </li></ol></fieldset> > > <fieldset class="action"> >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6573
:
4614
|
4615