From d043722fd34f8ce4d93853da896a10a9b818948f Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 21 Dec 2015 12:24:46 +0000 Subject: [PATCH] [PASSED QA] Bug 15367: Do not display repeatable patron attributes in the batch patron modification The repeatable patron attributes are not correctly managed and can cause data lost. To avoid that, the easier way is not to display them in the batch patron modification tool. This should be implemented, as a new enhancement. Test plan: Create some patron attributes, some should be repeatable. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as repeatable won't be display anymore. Signed-off-by: Bernardo Gonzalez Kriegel Works as described, no koha-qa errors Signed-off-by: Katrin Fischer --- tools/modborrowers.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl index 71588c0..f88581f 100755 --- a/tools/modborrowers.pl +++ b/tools/modborrowers.pl @@ -107,6 +107,9 @@ if ( $op eq 'show' ) { my $patron_categories = C4::Members::GetBorrowercategoryList; for ( values %$patron_attribute_types ) { my $attr_type = C4::Members::AttributeTypes->fetch( $_->{code} ); + # TODO Repeatable attributes are not correctly managed and can cause data lost. + # This should be implemented. + next if $attr_type->{repeatable}; my $options = $attr_type->authorised_value_category ? GetAuthorisedValues( $attr_type->authorised_value_category ) : undef; -- 1.9.1