Bugzilla – Attachment 4668 Details for
Bug 6600
Library name linking wrong if current location is different
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-Bug-6600-Library-name-linking-wrong-if-curre.patch (text/plain), 1.62 KB, created by
Owen Leonard
on 2011-07-19 13:20:56 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2011-07-19 13:20:56 UTC
Size:
1.62 KB
patch
obsolete
>From f9cb1a3bd41618323901d4e8c1fdc58e4fb6d2ec Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 19 Jul 2011 09:12:30 -0400 >Subject: [PATCH] Fix for Bug 6600, Library name linking wrong if current location is different >Content-Type: text/plain; charset="utf-8" > >GetItemsInfo in Items.pm includes this join: > >LEFT JOIN branches ON items.homebranch = branches.branchcode > >This means that the branch URL (from the branches table) comes out >as the URL for items.homebranch, thus the URL in the holdings >output is the item's home branch even though the display might >be showing a different current location. > >This patch changes the join to use items.holdingbranch. The join >was originally added to fix Bug 3702, and based on the description >of that feature I'm assuming this change is not harmful to other >usages. However, it does make the assumption that the item's >current (holding) branch is the branch we want to see information >about. >--- > C4/Items.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/C4/Items.pm b/C4/Items.pm >index 9342564..ed0a460 100644 >--- a/C4/Items.pm >+++ b/C4/Items.pm >@@ -1175,7 +1175,7 @@ sub GetItemsInfo { > itemtypes.notforloan as notforloan_per_itemtype, > branchurl > FROM items >- LEFT JOIN branches ON items.homebranch = branches.branchcode >+ LEFT JOIN branches ON items.holdingbranch = branches.branchcode > LEFT JOIN biblio ON biblio.biblionumber = items.biblionumber > LEFT JOIN biblioitems ON biblioitems.biblioitemnumber = items.biblioitemnumber > LEFT JOIN itemtypes ON itemtypes.itemtype = " >-- >1.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6600
: 4668