From 0e24b21a1f6ec54f1b1a0e07f313034702238f3f Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 27 Jun 2012 02:41:20 +1200 Subject: [PATCH] Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Record.pm Expression form of "eval" at line 358, column 5. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 367, column 5. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 510, column 3. See page 161 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart Signed-off-by: Bernardo Gonzalez Kriegel Fixed conflict Signed-off-by: Kyle M Hall --- C4/Record.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/C4/Record.pm b/C4/Record.pm index f46651b..efb14d3 100644 --- a/C4/Record.pm +++ b/C4/Record.pm @@ -380,7 +380,7 @@ sub marc2csv { } # Preprocessing - eval $preprocess if ($preprocess); + eval {$preprocess} if ($preprocess); my $firstpass = 1; if ( @$itemnumbers ) { @@ -397,7 +397,7 @@ sub marc2csv { } # Postprocessing - eval $postprocess if ($postprocess); + eval {$postprocess} if ($postprocess); return $output; } @@ -576,7 +576,7 @@ sub marcrecord2csv { # Field processing my $marcfield = $tag->{fieldtag}; # This line fixes a retrocompatibility concern # The "processing" could be based on the $marcfield variable. - eval $fieldprocessing if ($fieldprocessing); + eval {$fieldprocessing} if ($fieldprocessing); push @loop_values, $value; } -- 2.1.0