From 31aaa660109aff8c29ae9c3495c6d407c6e17032 Mon Sep 17 00:00:00 2001 From: Lari Taskula Date: Thu, 24 Sep 2015 13:17:39 +0300 Subject: [PATCH] Bug 14872: Reminder to update SMSnumber when primary phone is updated Since SMS number (smsalertnumber) and primary phone are separated, it would be useful to remind patron to update his/her SMS number when making changes to primary phone. This can easily be forgotten, especially in OPAC where the two fields are in different page (opac-memberentry.pl vs opac-messaging.pl). This patch adds a reminder in the "hint"-div that activates whenever phone field gets input (and phone-smsalertnumber do not match). To test: 1. Enable SMSSendDriver and EnhancedMessagingPreferences system preferences 2. Navigate to OPAC -> your personal details 3. Input something to primary phone. You should not be notified at all 4. Navigate to Intra -> Patron -> Edit 5. Repeat step 3 6. Apply patch 7. Refresh Opac -> your personal details and Intra -> Patron -> Edit 8. Input something to primary phone and observe you will be notified to also update SMS number. Signed-off-by: Aleisha Fixed a small merge conflict in opac-memberentry.tt --- .../prog/en/modules/members/memberentrygen.tt | 13 ++++++++++++- .../opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 12 ++++++++++++ opac/opac-memberentry.pl | 1 + 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt index d66357f..d8b5e0c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ -72,6 +72,17 @@ mrform.hide(); e.preventDefault(); }); + [% IF ( SMSSendDriver ) %] + $("#phone").on("input",function(e){ + if ($(this).val() != $("#SMSnumber").val()){ + $("#phone-reminder").css("display", "block"); + } else { + if ($("#phone-reminder").css("display") == "block") { + $("#phone-reminder").css("display", "none"); + } + } + }); + [% END %] }); function clear_entry(node) { @@ -530,7 +541,7 @@ [% END %] Primary phone: - [% IF ( mandatoryphone ) %]Required[% END %]
Shows on transit slips
+ [% IF ( mandatoryphone ) %]Required[% END %]
Shows on transit slips[% IF ( SMSSendDriver ) %][% END %]
[% END %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index 3f3428d..b4a3950 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -423,6 +423,7 @@ [% IF mandatory.defined('phone') %]Required[% END %] + [% IF ( SMSSendDriver ) %]
[% END %] [% END %] @@ -895,7 +896,18 @@ $('#update_privacy_guarantor_checkouts_message').fadeIn("slow").text( message ).delay( 5000 ).fadeOut("slow"); }); }); + [% IF ( SMSSendDriver ) %] + $("#borrower_phone").on("input",function(e){ + if ($(this).val() != "[% borrower.phone %]"){ + $("#phone-reminder").css("display", "block"); + } else { + if ($("#phone-reminder").css("display") == "block") { + $("#phone-reminder").css("display", "none"); + } + } + }); [% END %] + [% END %] }); //]]> diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl index 667f201..8997539 100755 --- a/opac/opac-memberentry.pl +++ b/opac/opac-memberentry.pl @@ -70,6 +70,7 @@ $template->param( member_titles => GetTitles() || undef, branches => GetBranchesLoop(), OPACPatronDetails => C4::Context->preference('OPACPatronDetails'), + SMSSendDriver => C4::Context->preference('SMSSendDriver'), ); if ( $action eq 'create' ) { -- 1.7.10.4