Bugzilla – Attachment 47792 Details for
Bug 14930
Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14930 - Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature
Bug-14930---Leaving-OpacFineNoRenewals-blank-block.patch (text/plain), 1.58 KB, created by
Jonathan Druart
on 2016-02-09 11:43:07 UTC
(
hide
)
Description:
Bug 14930 - Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-02-09 11:43:07 UTC
Size:
1.58 KB
patch
obsolete
>From 1a9cb5f3cd9c0c7bae3f8287ac43ea01c5f607f1 Mon Sep 17 00:00:00 2001 >From: Gus <gel1163@stacmail.net> >Date: Tue, 19 Jan 2016 03:12:48 +0000 >Subject: [PATCH] Bug 14930 - Leaving OpacFineNoRenewals blank blocks renewals, > but should disable feature >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To Test >- Borrower has some fines and checkouts >- Leave OPACFineNoRenewals empty/blank >- Try to renew items in the OPAC >- notice error message >- Add a big value to OpacFineNoRenewals >- notice renewals work > >Leaving the OPACFineNoRenewals empty will disable the feature. > >Patch works as expected.(Amended to format the commit message and to >remove a warn on line 112 / MV) >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > opac/opac-user.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/opac/opac-user.pl b/opac/opac-user.pl >index 9d1f9b2..e9529b5 100755 >--- a/opac/opac-user.pl >+++ b/opac/opac-user.pl >@@ -107,9 +107,9 @@ if ( 5 >= $borr->{'amountoutstanding'} && $borr->{'amountoutstanding'} > 0 ) { > $borr->{'amountoverzero'} = 1; > } > my $no_renewal_amt = C4::Context->preference( 'OPACFineNoRenewals' ); >-$no_renewal_amt ||= 0; >+$no_renewal_amt ||= undef; > >-if ( C4::Context->preference( 'OpacRenewalAllowed' ) && $borr->{amountoutstanding} > $no_renewal_amt ) { >+if ( C4::Context->preference( 'OpacRenewalAllowed' ) && $no_renewal_amt && $borr->{amountoutstanding} > $no_renewal_amt ) { > $borr->{'flagged'} = 1; > $canrenew = 0; > $template->param( >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14930
:
46845
|
46846
|
47271
|
47466
|
47652
|
47653
| 47792 |
47793