From cd7e88ea473eb650474053c5a5f7c12a6150e93e Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Wed, 13 Jan 2016 16:04:53 +0000
Subject: [PATCH] Bug 14610 [QA Followup] - Add "All libraries" option to
 article-requests.pl

---
 circ/article-requests.pl                                         | 2 +-
 koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/circ/article-requests.pl b/circ/article-requests.pl
index 816c736..d0c2805 100755
--- a/circ/article-requests.pl
+++ b/circ/article-requests.pl
@@ -36,7 +36,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     }
 );
 
-my $branchcode = $query->param('branchcode') || C4::Context->userenv->{'branch'};
+my $branchcode = defined( $query->param('branchcode') ) ? $query->param('branchcode') : C4::Context->userenv->{'branch'};
 
 $template->param(
     branchcode                  => $branchcode,
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt
index 9dfd2ab..8e8b994 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt
@@ -122,6 +122,7 @@
 
                 <form id="ar-branchcode-form" method="post">
                     <select name="branchcode" id="branchcode">
+                        <option value="">All libraries</option>
                         [% FOREACH b IN Branches.all %]
                             [% IF b.branchcode == branchcode %]
                                 <option value="[% b.branchcode %]" selected="selected">[% b.branchname %]</option>
@@ -130,7 +131,9 @@
                             [% END %]
                         [% END %]
                     </select>
-                    <input class="btn btn-small" type="submit" value="Update" />
+                    <button type="submit" class="btn btn-small" type="submit">
+                        <i class="fa fa-refresh"></i> Update
+                    </button>
                 </form>
 
                 <div id="article-request-tabs" class="toptabs">
-- 
2.1.4