From 8834e19918c46b47caecf0249f95eb720885f0d7 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 16 Feb 2016 16:28:33 +0000 Subject: [PATCH] Bug 15839: Koha::Reviews - Remove updatereview --- C4/Review.pm | 19 +------------------ opac/opac-review.pl | 11 +++++++++-- 2 files changed, 10 insertions(+), 20 deletions(-) diff --git a/C4/Review.pm b/C4/Review.pm index f5121f1..6308926 100644 --- a/C4/Review.pm +++ b/C4/Review.pm @@ -29,7 +29,7 @@ BEGIN { $VERSION = 3.07.00.049; require Exporter; @ISA = qw(Exporter); - @EXPORT = qw(savereview updatereview numberofreviewsbybiblionumber); + @EXPORT = qw(savereview numberofreviewsbybiblionumber); } =head1 NAME @@ -41,7 +41,6 @@ C4::Review - Perl Module containing routines for dealing with reviews of items use C4::Review; savereview($biblionumber,$borrowernumber,$review); - updatereview($biblionumber,$borrowernumber,$review); my $count=numberofreviewsbybiblionumber($biblionumber); =head1 DESCRIPTION @@ -68,22 +67,6 @@ sub savereview { $sth->execute( $borrowernumber, $biblionumber, $review ); } -=head2 updatereview - - updateview($biblionumber,$borrowernumber, $review); - -Update the review description in the 'reviews' database - -=cut - -sub updatereview { - my ( $biblionumber, $borrowernumber, $review ) = @_; - my $dbh = C4::Context->dbh; - my $query = "UPDATE reviews SET review=?,datereviewed=now(),approved=0 WHERE borrowernumber=? and biblionumber=?"; - my $sth = $dbh->prepare($query); - $sth->execute( $review, $borrowernumber, $biblionumber ); -} - =head2 numberofreviewsbybiblionumber my $count=numberofreviewsbybiblionumber($biblionumber); diff --git a/opac/opac-review.pl b/opac/opac-review.pl index e3fc3b3..1b3640a 100755 --- a/opac/opac-review.pl +++ b/opac/opac-review.pl @@ -26,6 +26,7 @@ use C4::Review; use C4::Biblio; use C4::Scrubber; use C4::Debug; +use Koha::DateUtils; use Koha::Reviews; my $query = new CGI; @@ -60,8 +61,14 @@ if (defined $review) { my $js_ok_review = $clean; $js_ok_review =~ s/"/"/g; # probably redundant w/ TMPL ESCAPE=JS $template->param(clean_review=>$js_ok_review); - if ($savedreview) { - updatereview($biblionumber, $borrowernumber, $clean); + if ($savedreview) { + $savedreview->set( + { + review => $clean, + approved => 0, + datereviewed => dt_from_string + } + )->store; } else { savereview($biblionumber, $borrowernumber, $clean); } -- 2.7.0