Bugzilla – Attachment 48204 Details for
Bug 15747
Auth.pm flooding error log with "CGI::param called in list context"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15747: Do not use CGI->param in list context - Auth.pm
Bug-15747-Do-not-use-CGI-param-in-list-context---A.patch (text/plain), 1.20 KB, created by
Marcel de Rooy
on 2016-02-18 10:47:36 UTC
(
hide
)
Description:
Bug 15747: Do not use CGI->param in list context - Auth.pm
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-02-18 10:47:36 UTC
Size:
1.20 KB
patch
obsolete
>From ceeed937ca36daf78c74c28997a3cc02d3cc9779 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 12 Feb 2016 11:47:22 +0000 >Subject: [PATCH] Bug 15747: Do not use CGI->param in list context - Auth.pm >Content-Type: text/plain; charset=utf-8 > >Test plan: >Log you in! >Without this patch applied, you will get a warning >"Fetching the value or values of a single named parameter" >With this patch applied, the warning from C4::Auth line 401 should not >appear anymore in the log file. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Note: no warnings for older CGI versions. >--- > C4/Auth.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 9481f73..4ccacd8 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -398,7 +398,7 @@ sub get_template_and_user { > $template->param( dateformat => C4::Context->preference('dateformat') ); > } > >- $template->param(auth_forwarded_hash => $in->{'query'}->param('auth_forwarded_hash')); >+ $template->param(auth_forwarded_hash => scalar $in->{'query'}->param('auth_forwarded_hash')); > > # these template parameters are set the same regardless of $in->{'type'} > >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15747
:
47901
|
47903
|
47960
|
47966
|
48067
| 48204