@@ -, +, @@ when importing patrons --------- -- sample provided to trigger error. -- you will get a DBIx::class exception "Duplicate entry ' for key 'userid'" -- patrons won't be inserted but an error will be nicely displayed in the error list. --- koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt | 5 +++++ tools/import_borrowers.pl | 7 +++++++ 2 files changed, 12 insertions(+) --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt +++ a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt @@ -90,6 +90,11 @@ [% IF ERROR.borrowernumber %] (for patron with borrowernumber [% ERROR.borrowernumber %])[% END %] [% END %] + [% IF ERROR.duplicate_userid %] +
  • + Userid [% ERROR.userid %] is already used by another patron or is empty. +
  • + [% END %] [% END %] --- a/tools/import_borrowers.pl +++ a/tools/import_borrowers.pl @@ -253,6 +253,13 @@ if ( $uploadborrowers && length($uploadborrowers) > 0 ) { next; } + # generate a proper login if none provided + if ( $borrower{userid} eq '' || !Check_Userid( $borrower{userid} ) ) { + push @errors, { duplicate_userid => 1, userid => $borrower{userid} }; + $invalid++; + next LINE; + } + if ($borrowernumber) { # borrower exists --