From ae8c28e38f52e260451b280fe1cc05a116e768b3 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 24 Feb 2016 15:05:01 +0000 Subject: [PATCH] Bug 15899 - Remove C4::Accounts::recordpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) git grep recordpayment should show no calls to the recordpayment sub --- C4/Accounts.pm | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/C4/Accounts.pm b/C4/Accounts.pm index 1304e15..1c50bd6 100644 --- a/C4/Accounts.pm +++ b/C4/Accounts.pm @@ -37,7 +37,6 @@ BEGIN { require Exporter; @ISA = qw(Exporter); @EXPORT = qw( - &recordpayment &makepayment &manualinvoice &getnextacctno @@ -70,33 +69,6 @@ patron. =head1 FUNCTIONS -=head2 recordpayment - - &recordpayment($borrowernumber, $payment, $sip_paytype, $note); - -Record payment by a patron. C<$borrowernumber> is the patron's -borrower number. C<$payment> is a floating-point number, giving the -amount that was paid. C<$sip_paytype> is an optional flag to indicate this -payment was made over a SIP2 interface, rather than the staff client. The -value passed is the SIP2 payment type value (message 37, characters 21-22) - -Amounts owed are paid off oldest first. That is, if the patron has a -$1 fine from Feb. 1, another $1 fine from Mar. 1, and makes a payment -of $1.50, then the oldest fine will be paid off in full, and $0.50 -will be credited to the next one. - -=cut - -#' -sub recordpayment { - - #here we update the account lines - my ( $borrowernumber, $data, $sip_paytype, $payment_note ) = @_; - - return Koha::Account->new( { patron_id => $borrowernumber } ) - ->pay( { amount => $data, sip => $sip_paytype, note => $payment_note } ); -} - =head2 makepayment &makepayment($accountlines_id, $borrowernumber, $acctnumber, $amount, $branchcode); -- 2.1.4