Bugzilla – Attachment 4837 Details for
Bug 6667
Return from C4::Members::GetBorNotifyAcctRecord differs from that in perldoc
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed Patch
0001-Bug-6667-Correct-documentation-of-function.patch (text/plain), 1.70 KB, created by
Colin Campbell
on 2011-08-04 12:02:41 UTC
(
hide
)
Description:
Proposed Patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2011-08-04 12:02:41 UTC
Size:
1.70 KB
patch
obsolete
>From e9a5048ae2c14f2b343ce773c67a13ab5e41d907 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Thu, 4 Aug 2011 12:57:52 +0100 >Subject: [PATCH] Bug 6667 Correct documentation of function >Content-Type: text/plain; charset="utf-8" > >Return list was documented as being in the reverse order >to how it is returned. Correct the perldoc description > >also removed comments which did not help anyone trying >to make sense of this subroutine >--- > C4/Members.pm | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > >diff --git a/C4/Members.pm b/C4/Members.pm >index 2ce3030..00758b8 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -1191,12 +1191,10 @@ sub GetMemberAccountRecords { > > =head2 GetBorNotifyAcctRecord > >- ($count, $acctlines, $total) = &GetBorNotifyAcctRecord($params,$notifyid); >+ ($total, $acctlines, $count) = &GetBorNotifyAcctRecord($params,$notifyid); > > Looks up accounting data for the patron with the given borrowernumber per file number. > >-(FIXME - I'm not at all sure what this is about.) >- > C<&GetBorNotifyAcctRecord> returns a three-element array. C<$acctlines> is a > reference-to-array, where each element is a reference-to-hash; the > keys are the fields of the C<accountlines> table in the Koha database. >@@ -1218,7 +1216,6 @@ sub GetBorNotifyAcctRecord { > AND amountoutstanding != '0' > ORDER BY notify_id,accounttype > "); >-# AND (accounttype='FU' OR accounttype='N' OR accounttype='M'OR accounttype='A'OR accounttype='F'OR accounttype='L' OR accounttype='IP' OR accounttype='CH' OR accounttype='RE' OR accounttype='RL') > > $sth->execute( $borrowernumber, $notifyid ); > my $total = 0; >-- >1.7.6 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6667
:
4837
|
4842