Bugzilla – Attachment 48553 Details for
Bug 15960
Use Font Awesome icons for classification filing rule deletion error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15960 - Use Font Awesome icons for classification filing rule deletion error
Bug-15960---Use-Font-Awesome-icons-for-classificat.patch (text/plain), 2.03 KB, created by
Owen Leonard
on 2016-03-02 16:58:54 UTC
(
hide
)
Description:
Bug 15960 - Use Font Awesome icons for classification filing rule deletion error
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2016-03-02 16:58:54 UTC
Size:
2.03 KB
patch
obsolete
>From 9a3084fd9180160f1e47c0134d49533c5bc106ce Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 2 Mar 2016 11:54:02 -0500 >Subject: [PATCH] Bug 15960 - Use Font Awesome icons for classification filing > rule deletion error >Content-Type: text/plain; charset="utf-8" > >When deletion of a classification filing rule is impossible, the dialog >saying so should be styled with Font Awesome icons. This patch corrects >this omission from the patch for Bug 15785. > >Also changed: The dialog is now an "alert" style dialog instead of a >"message" one. > >To test, apply the patch and go to Administration -> Classification >sources. > >- Locate a classification filing rule which is in use by a > classification source. >- Click the "Delete" link for that rule and verify that the resulting > dialog is correctly styled. >- Click the "OK" button and confirm that you are correctly redirected. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >index 9c854eb..fd31671 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >@@ -216,12 +216,12 @@ function CheckRuleForm(f) { > [% END %] > > [% IF ( delete_sort_rule_impossible ) %] >-<div class="dialog message"><h3>Cannot delete filing rule <span class="ex">'[% sort_rule %]'</span></h3> >+<div class="dialog alert"><h3>Cannot delete filing rule <span class="ex">'[% sort_rule %]'</span></h3> > <p>The filing rule [% sort_rule %] is used by at least one classification source. Please > remove it from all classification source definitions before trying again. > </p> > <form action="[% script_name %]" method="get"> >- <input type="submit" value="OK" class="approve" /> >+ <button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> OK</button> > </form> > </div> > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15960
:
48553
|
48627
|
48937