From 9f318a01465fded20d024a7eca4515832fb1ad85 Mon Sep 17 00:00:00 2001 From: Josef Moravec Date: Wed, 2 Mar 2016 11:16:40 +0100 Subject: [PATCH] [SIGNED-OFF]Bug 15964: Followup: make module WWW::YouTube::Download required Module C4::HTML5Media is used in detail.pl, so if you don't have installled module for YouTube, you get an internal server error. This patch make module WWW::YouTube::Download required and adds it to package dependencies Test plan: 1. Don't have installed module WWW::YouTube:Download, neither package libwww-youtube-download-perl 2. Try to access biblio detail in staff client (detail.pl) - you'll be presented withh internal server error 3. Check the About page -> Perl modules, the WWW::YouTube::Download should be reported as missing optional 4. Apply the patch 5. Check the About page -> Perl modules, the WWW::YouTube::Download should now be reported as missing required 6. Create and install debian package, the libwww-youtube-download-perl should be the dependency and so installed with koha-common package (use apt-get install -f, if neccessery) 7. Check the About page -> Perl modules, the WWW::YouTube::Download should now be reported as Module current 8. Try to access biblio detail in staff client (detail.pl) - it should be display, no error now Signed-off-by: Hector Castro Works as advertised --- C4/Installer/PerlDependencies.pm | 2 +- debian/control | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm index 5e2f22f..6e1f6c5 100644 --- a/C4/Installer/PerlDependencies.pm +++ b/C4/Installer/PerlDependencies.pm @@ -784,7 +784,7 @@ our $PERL_DEPS = { }, 'WWW::YouTube::Download' => { 'usage' => 'HTML5Media streaming from YouTube', - 'required' => '0', + 'required' => '1', 'min_ver' => '0.56', }, }; diff --git a/debian/control b/debian/control index d8a5caf..264fc1e 100644 --- a/debian/control +++ b/debian/control @@ -121,6 +121,7 @@ Build-Depends: libalgorithm-checkdigits-perl, liburi-perl, libuuid-perl, libwww-perl, + libwww-youtube-download-perl, libxml-dumper-perl, libxml-libxml-perl, libxml-libxslt-perl, @@ -328,6 +329,7 @@ Depends: libalgorithm-checkdigits-perl, liburi-perl, libuuid-perl, libwww-perl, + libwww-youtube-download-perl, libxml-dumper-perl, libxml-libxml-perl, libxml-libxslt-perl, -- 1.7.10.4