From e31ea0a18364ab3d5f984c1f3f029ec66b34a31c Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Tue, 1 Mar 2016 14:49:20 +0000
Subject: [PATCH] Bug 14757 [QA Followup] - Change method type() to _type() for
 Koha objects

---
 Koha/Borrower/Modification.pm  | 2 +-
 Koha/Borrower/Modifications.pm | 2 +-
 Koha/Checkout.pm               | 2 +-
 Koha/Checkouts.pm              | 2 +-
 Koha/News.pm                   | 2 +-
 Koha/NewsItem.pm               | 2 +-
 Koha/Suggestion.pm             | 2 +-
 Koha/Suggestions.pm            | 2 +-
 tools/letter.pl                | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/Koha/Borrower/Modification.pm b/Koha/Borrower/Modification.pm
index ceb9df2..35f56f4 100644
--- a/Koha/Borrower/Modification.pm
+++ b/Koha/Borrower/Modification.pm
@@ -39,7 +39,7 @@ Koha::Item - Koha Item object class
 
 =cut
 
-sub type {
+sub _type {
     return 'BorrowerModification';
 }
 
diff --git a/Koha/Borrower/Modifications.pm b/Koha/Borrower/Modifications.pm
index 7c92fcf..4141eb2 100644
--- a/Koha/Borrower/Modifications.pm
+++ b/Koha/Borrower/Modifications.pm
@@ -312,7 +312,7 @@ sub GetModifications {
     return $data;
 }
 
-sub type {
+sub _type {
     return 'BorrowerModification';
 }
 
diff --git a/Koha/Checkout.pm b/Koha/Checkout.pm
index 5085cf2..358f41c 100644
--- a/Koha/Checkout.pm
+++ b/Koha/Checkout.pm
@@ -39,7 +39,7 @@ Koha::Checkout - Koha Checkout object class
 
 =cut
 
-sub type {
+sub _type {
     return 'Issue';
 }
 
diff --git a/Koha/Checkouts.pm b/Koha/Checkouts.pm
index b2781c6..374cfb1 100644
--- a/Koha/Checkouts.pm
+++ b/Koha/Checkouts.pm
@@ -41,7 +41,7 @@ Koha::Checkouts - Koha Checkout object set class
 
 =cut
 
-sub type {
+sub _type {
     return 'Issue';
 }
 
diff --git a/Koha/News.pm b/Koha/News.pm
index f57d07b..4a3d759 100644
--- a/Koha/News.pm
+++ b/Koha/News.pm
@@ -41,7 +41,7 @@ Koha::News - Koha News object set class
 
 =cut
 
-sub type {
+sub _type {
     return 'OpacNews';
 }
 
diff --git a/Koha/NewsItem.pm b/Koha/NewsItem.pm
index c7d9efc..9d0dd63 100644
--- a/Koha/NewsItem.pm
+++ b/Koha/NewsItem.pm
@@ -41,7 +41,7 @@ Koha::NewsItem represents a single piece of news from the opac_news table
 
 =cut
 
-sub type {
+sub _type {
     return 'OpacNews';
 }
 
diff --git a/Koha/Suggestion.pm b/Koha/Suggestion.pm
index da7f3d4..a091f43 100644
--- a/Koha/Suggestion.pm
+++ b/Koha/Suggestion.pm
@@ -39,7 +39,7 @@ Koha::Suggestion - Koha Suggestion object class
 
 =cut
 
-sub type {
+sub _type {
     return 'Suggestion';
 }
 
diff --git a/Koha/Suggestions.pm b/Koha/Suggestions.pm
index 4202bab..73ad28d 100644
--- a/Koha/Suggestions.pm
+++ b/Koha/Suggestions.pm
@@ -41,7 +41,7 @@ Koha::Suggestions - Koha Suggestion object set class
 
 =cut
 
-sub type {
+sub _type {
     return 'Suggestion';
 }
 
diff --git a/tools/letter.pl b/tools/letter.pl
index e1833c3..24a8a46 100755
--- a/tools/letter.pl
+++ b/tools/letter.pl
@@ -260,7 +260,7 @@ sub add_validate {
     my @content       = $input->param('content');
     for my $mtt ( @mtt ) {
         my $is_html = $input->param("is_html_$mtt");
-        my $is_tt = $input->param("is_tt_$mtt");
+        my $is_tt = $input->param("is_tt_$mtt") ? 1 : 0;
         my $title   = shift @title;
         my $content = shift @content;
         my $letter = C4::Letters::getletter( $oldmodule, $code, $branchcode, $mtt);
-- 
2.1.4