Attachment 48664 Details for Bug 15956 – Bug 15956: Remove warn from handle_patron_status

[patch] Bug 15956: Remove warn from handle_patron_status

Bug-15956-Remove-warn-from-handlepatronstatus.patch (text/plain), 1.34 KB, created by Marcel de Rooy on 2016-03-04 10:14:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2016-03-04 10:14:41 UTC

Size: 1.34 KB

patch

obsolete

>From 7bb02a0c00ed433cc387d8f76f098add5c372fbf Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 2 Mar 2016 14:20:59 +0100
>Subject: [PATCH] Bug 15956: Remove warn from handle_patron_status
>Content-Type: text/plain; charset=utf-8
>
>Removes a warn and some commented warns.
>
>Test plan:
>Nothing to do here. Will be covered later by additional unit test.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/SIP/Sip/MsgType.pm |    4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm
>index bd6f05b..bbde751 100644
>--- a/C4/SIP/Sip/MsgType.pm
>+++ b/C4/SIP/Sip/MsgType.pm
>@@ -468,7 +468,6 @@ sub build_patron_status {
> 
> sub handle_patron_status {
>     my ( $self, $server ) = @_;
>-    warn "handle_patron_status server: " . Dumper( \$server );
>     my $ils = $server->{ils};
>     my $patron;
>     my $resp    = (PATRON_STATUS_RESP);
>@@ -476,9 +475,6 @@ sub handle_patron_status {
>     my ( $lang, $date ) = @{ $self->{fixed_fields} };
>     my $fields = $self->{fields};
> 
>-    #warn Dumper($fields);
>-    #warn FID_INST_ID;
>-    #warn $fields->{(FID_INST_ID)};
>     $ils->check_inst_id( $fields->{ (FID_INST_ID) }, "handle_patron_status" );
>     $patron = $ils->find_patron( $fields->{ (FID_PATRON_ID) } );
>     $resp = build_patron_status( $patron, $lang, $fields, $server );
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 15956: 48544 | 48545 | 48546 | 48547 | 48656 | 48663 | 48664 | 48665 | 48666 | 50239 | 50240 | 50241 | 50242 | 50765 | 50766 | 50767 | 50768