From 39ae7264ad55c81c6101a280a6df0d7a38507c2c Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Thu, 27 Aug 2015 10:01:53 +0200 Subject: [PATCH] [PASSED QA] Bug 14306: Remove call to GetMarcNotes from sendshelf MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Just as mentioned in the first patch for sendbasket, I discovered that the call of GetMarcNotes is not really used in sendshelf. The array is passed to the template, but the template does not use it. (It uses the information from GetBiblioData.) Test plan: [1] Send a list that includes a record with some notes (opac and staff). Signed-off-by: Marc VĂ©ron Signed-off-by: Katrin Fischer --- opac/opac-sendshelf.pl | 2 -- virtualshelves/sendshelf.pl | 2 -- 2 files changed, 4 deletions(-) diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl index d4d31d8..a0682bc 100755 --- a/opac/opac-sendshelf.pl +++ b/opac/opac-sendshelf.pl @@ -90,7 +90,6 @@ if ( $email ) { my $fw = GetFrameworkCode($biblionumber); my $dat = GetBiblioData($biblionumber); my $record = GetMarcBiblio($biblionumber, 1); - my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour ); my $subtitle = GetRecordValue('subtitle', $record, $fw); @@ -98,7 +97,6 @@ if ( $email ) { my @items = GetItemsInfo( $biblionumber ); $dat->{ISBN} = GetMarcISBN($record, $marcflavour); - $dat->{MARCNOTES} = $marcnotesarray; $dat->{MARCSUBJCTS} = $marcsubjctsarray; $dat->{MARCAUTHORS} = $marcauthorsarray; $dat->{'biblionumber'} = $biblionumber; diff --git a/virtualshelves/sendshelf.pl b/virtualshelves/sendshelf.pl index cb46ce2..02999ea 100755 --- a/virtualshelves/sendshelf.pl +++ b/virtualshelves/sendshelf.pl @@ -81,7 +81,6 @@ if ($email) { my $fw = GetFrameworkCode($biblionumber); my $dat = GetBiblioData($biblionumber); my $record = GetMarcBiblio($biblionumber, 1); - my $marcnotesarray = GetMarcNotes( $record, $marcflavour ); my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour ); my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour ); my $subtitle = GetRecordValue( 'subtitle', $record, $fw ); @@ -89,7 +88,6 @@ if ($email) { my @items = GetItemsInfo($biblionumber); $dat->{ISBN} = GetMarcISBN($record, $marcflavour); - $dat->{MARCNOTES} = $marcnotesarray; $dat->{MARCSUBJCTS} = $marcsubjctsarray; $dat->{MARCAUTHORS} = $marcauthorsarray; $dat->{'biblionumber'} = $biblionumber; -- 1.9.1