Bugzilla – Attachment 48751 Details for
Bug 15983
Use Font Awesome icons in serial numbering pattern deletion confirmation dialog
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF]Bug 15983: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog
SIGNED-OFFBug-15983-Use-Font-Awesome-icons-in-seri.patch (text/plain), 3.62 KB, created by
Héctor Eduardo Castro Avalos
on 2016-03-07 15:09:01 UTC
(
hide
)
Description:
[SIGNED-OFF]Bug 15983: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog
Filename:
MIME Type:
Creator:
Héctor Eduardo Castro Avalos
Created:
2016-03-07 15:09:01 UTC
Size:
3.62 KB
patch
obsolete
>From af13c207e89e63572ce4239ad112518ce3e35faa Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 4 Mar 2016 12:29:03 -0500 >Subject: [PATCH] [SIGNED-OFF]Bug 15983: Use Font Awesome icons in serial > numbering pattern deletion confirmation dialog > >If you try to delete a serial numbering pattern which is in use by an >existing subscription you will be shown a confirmation dialog. This >dialog should use Font Awesome icons. > >Other minor changes: > >- Added "action" attributes to <form>s to fix validation errors. >- Added "alert" class to confirmation dialogs so that they correctly > styled. > >To test, apply the patch and go to Serials -> Numbering patterns. > >- Click "Delete" on a numbering pattern which is in use by a > subscription. >- Verify that the confirmation dialog is styled correctly. >- Test that the "No, do not delete" button works correctly. >- Test that the "Yes, delete" button deletes the correct numbering > pattern. > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Works as described >--- > .../en/modules/serials/subscription-numberpatterns.tt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >index e0c56fe..e1921a9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt >@@ -81,14 +81,14 @@ function show_blocking_subs() { > [% IF (new) %] > <h1>New numbering pattern</h1> > [% IF (error_existing_numberpattern) %] >- <div class="dialog"> >+ <div class="dialog alert"> > <p>A pattern with this name already exists.</p> > </div> > [% END %] > [% ELSE %] > <h1>Modify pattern: [% label %]</h1> > [% IF (error_existing_numberpattern) %] >- <div class="dialog"> >+ <div class="dialog alert"> > <p>Another pattern with this name already exists.</p> > </div> > [% END %] >@@ -268,7 +268,7 @@ function show_blocking_subs() { > [% ELSE %] > <h1>Numbering patterns</h1> > [% IF still_used %] >- <div class="dialog"> >+ <div class="dialog alert"> > <p> > This pattern is still used by [% subscriptions.size %] > subscription(s). Do you still want to delete it? >@@ -282,14 +282,14 @@ function show_blocking_subs() { > [% END %] > </ul> > >- <form action="" method="get"> >+ <form action="/cgi-bin/koha/serials/subscription-numberpatterns.pl" method="get"> > <input type="hidden" name="op" value="del" /> > <input type="hidden" name="confirm" value="1" /> > <input type="hidden" name="id" value="[% id %]" /> >- <input type="submit" class="approve" value="Yes, delete" /> >+ <button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> Yes, delete</button> > </form> >- <form action="" method="get"> >- <input type="submit" class="deny" value="No, don't delete" /> >+ <form action="/cgi-bin/koha/serials/subscription-numberpatterns.pl" method="get"> >+ <button type="submit" class="deny"><i class="fa fa-fw fa-remove"></i> No, do not delete</button> > </form> > </div> > [% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15983
:
48702
|
48751
|
48944