Bugzilla – Attachment 48776 Details for
Bug 15741
Incorrect rounding in total fines calculations
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15741: Fix rounding in total fines calculations
Bug-15741-Fix-rounding-in-total-fines-calculations.patch (text/plain), 1.20 KB, created by
Jonathan Druart
on 2016-03-08 12:01:22 UTC
(
hide
)
Description:
Bug 15741: Fix rounding in total fines calculations
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-03-08 12:01:22 UTC
Size:
1.20 KB
patch
obsolete
>From f39ae438aae9ff6d63747e5c39b8590aace7bf9e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 8 Mar 2016 11:58:24 +0000 >Subject: [PATCH] Bug 15741: Fix rounding in total fines calculations > >C4::Members::GetMemberAccountRecords wrongly casts float to integer >It's common to use sprintf in Perl to do this job. > >% perl -e 'print int(1000*64.60)."\n"'; >64599 >% perl -e 'print sprintf("%.0f", 1000*64.60)."\n"'; >64600 > >Test plan: >1) Create manual invoice for 64.60 (or 1.14, 1.36, ...) >2) Try to pay it using "Pay amount" or "Pay selected" buttons >--- > C4/Members.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Members.pm b/C4/Members.pm >index cc438f0..142aba8 100644 >--- a/C4/Members.pm >+++ b/C4/Members.pm >@@ -1172,7 +1172,7 @@ sub GetMemberAccountRecords { > } > $acctlines[$numlines] = $data; > $numlines++; >- $total += int(1000 * $data->{'amountoutstanding'}); # convert float to integer to avoid round-off errors >+ $total += sprintf "%.0f", 1000*$data->{amountoutstanding}; # convert float to integer to avoid round-off errors > } > $total /= 1000; > return ( $total, \@acctlines,$numlines); >-- >2.7.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15741
:
48776
|
49087
|
49484
|
49495
|
49496