Bugzilla – Attachment 48847 Details for
Bug 16013
Classification sources are not deletable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16013: Make classification sources deletable
Bug-16013-Make-classification-sources-deletable.patch (text/plain), 1.33 KB, created by
Jonathan Druart
on 2016-03-09 11:30:42 UTC
(
hide
)
Description:
Bug 16013: Make classification sources deletable
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-03-09 11:30:42 UTC
Size:
1.33 KB
patch
obsolete
>From 8ca1bea4e9c09353a88bab7b906a638f9d69b5be Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 9 Mar 2016 11:28:04 +0000 >Subject: [PATCH] Bug 16013: Make classification sources deletable > >Because of a wrong variable scope, the classification sources are not >deletable. > >Test plan: >Create a classification sources (admin/classsources.pl) >Try to delete it >Without this patch, the classification source won't be deleted >With this patch, it will work! >--- > admin/classsources.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/admin/classsources.pl b/admin/classsources.pl >index 0b7ee31..cc2fe87 100755 >--- a/admin/classsources.pl >+++ b/admin/classsources.pl >@@ -58,7 +58,7 @@ if ($op eq "add_source") { > $rule_code); > $display_lists = 1; > } elsif ($op eq "delete_source") { >- delete_class_source_form($template); >+ delete_class_source_form($template, $source_code); > } elsif ($op eq "delete_source_confirmed") { > delete_class_source($template, $source_code); > $display_lists = 1; >@@ -146,7 +146,7 @@ sub edit_class_source { > > > sub delete_class_source_form { >- my ($template) = @_; >+ my ($template, $source_code) = @_; > $template->param( > delete_class_source_form => 1, > confirm_op => "delete_source_confirmed", >-- >2.7.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16013
:
48847
|
49081
|
49338