From c5e1220ae4a7e209202f1451de9c148a5e8c9f8e Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 9 Mar 2016 11:48:39 -0500 Subject: [PATCH] Bug 10612 [Follow-up] Combine and clarify menu items Content-Type: text/plain; charset="utf-8" This follow-up patch for Bug 10612 moves all list operations into one menu while (hopefully) clarifying the labels for each. Also in this patch: Changed datatables sorting configuration to use the "nosort" attribute. To test, apply the patch and go to Tools -> Patron lists. - On a patron list with no patrons, confirm that the "Actions" menu lists "Add patrons," "Edit list," and "Delete list." - On a patron list containing one or more patrons, confirm that the "Actions" menu /also/ has these options: "Print patron cards," "Batch edit patrons," and "Batch delete patrons." - Confirm that the "actions" column is not sortable. - Test logging in as a user who has various combinations of permission to batch edit and batch delete. --- .../prog/en/modules/patron_lists/lists.tt | 47 ++++++++++------------ 1 file changed, 22 insertions(+), 25 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt index 779058f..b10e34f 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt @@ -11,7 +11,7 @@ $('#patron-lists-table').dataTable($.extend(true, {}, dataTablesDefaults, { "autoWidth": false, "aoColumnDefs": [ - { "aTargets": [ -1 ], "bSortable": false, "bSearchable": false }, + { "bSortable": false, "bSearchable": false, 'aTargets': [ 'NoSort' ] } ], "sPaginationType": "four_button" } )); @@ -48,13 +48,7 @@ Name Patrons in list -   - [% IF CAN_user_tools_edit_patrons %] -   - [% END %] - [% IF CAN_user_tools_delete_anonymize_patrons %] -   - [% END %] +   @@ -70,26 +64,29 @@ - [% IF CAN_user_tools_edit_patrons %] - - - Edit patrons - - - [% END %] - [% IF CAN_user_tools_delete_anonymize_patrons %] - - - Delete patrons - - - [% END %] [% END %] -- 2.1.4