Bugzilla – Attachment 49248 Details for
Bug 16032
Use Font Awesome icon in "note" styled divs
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16032 - Use Font Awesome icon in "note" styled divs
Bug-16032---Use-Font-Awesome-icon-in-note-styled-d.patch (text/plain), 9.28 KB, created by
Jonathan Druart
on 2016-03-17 09:30:22 UTC
(
hide
)
Description:
Bug 16032 - Use Font Awesome icon in "note" styled divs
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-03-17 09:30:22 UTC
Size:
9.28 KB
patch
obsolete
>From 433eccb412202713df4e860a59127dac5aa459da Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 9 Mar 2016 13:58:17 -0500 >Subject: [PATCH] Bug 16032 - Use Font Awesome icon in "note" styled divs >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Several pages use <div class="note"> to display important information >about the functionality on the page. The style of this div can be >modified to use Font Awesome, eliminating an image file. > >To test, apply the patch and clear your browser cache if necessary. > >- Go to Administration -> Authorized values. >- Confirm that the "NOTE" box is styled correctly. >- Edit an existing authorized value. >- Confirm that the "NOTE" box is styled correctly. > >- Go to Tools -> Batch record deletion. >- Submit a batch of biblionumbers. >- Confirm that the "Reminder" box is styled correctly. >- Go back and submit a batch of authority numbers. >- Confirm that the "Reminder" box is styled correctly. > >- Go to Tools -> Batch record modification. >- Submit a batch of biblionumbers. >- Confirm that the "Reminder" box is styled correctly. >- Go back and submit a batch of authority numbers. >- Confirm that the "Reminder" box is styled correctly. > >- Check that there are no other references to "note.png" in the > templates. > >Followed test plan, works as expected >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../intranet-tmpl/prog/en/css/staff-global.css | 33 +++++++++++---------- > .../prog/en/modules/admin/authorised_values.tt | 4 +-- > .../prog/en/modules/tools/batch_delete_records.tt | 4 +-- > .../en/modules/tools/batch_record_modification.tt | 4 +-- > koha-tmpl/intranet-tmpl/prog/img/note.png | Bin 511 -> 0 bytes > 5 files changed, 24 insertions(+), 21 deletions(-) > delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/note.png > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >index e6116ce..ca9065c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >@@ -1278,22 +1278,25 @@ div.message ul+h4 { > } > > div.note { >- background: #f4f6fa; >- background-repeat : no-repeat; >- background-position : left center; >- background-image : url("../../img/note.png"); >- background-image: url("../../img/note.png"), -moz-linear-gradient(top, #f4f6fa 0%, #e8edf6 100%); /* FF3.6+ */ >- background-image: url("../../img/note.png"), -webkit-gradient(linear, left top, left bottom, color-stop(0%,#f4f6fa), color-stop(100%,#e8edf6)); /* Chrome,Safari4+ */ >- background-image: url("../../img/note.png"), -webkit-linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* Chrome10+,Safari5.1+ */ >- background-image: url("../../img/note.png"), -o-linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* Opera11.10+ */ >- background-image: url("../../img/note.png"), -ms-linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* IE10+ */ >- filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#f4f6fa', endColorstr='#e8edf6',GradientType=0 ); /* IE6-9 */ >- background-image: url("../../img/note.png"), linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* W3C */ >- border : 1px solid #BCBCBC; >- padding : .5em .5em .5em 20px; >- margin : .5em 0; >+ background: #f4f6fa; >+ background: -moz-linear-gradient(top, #f4f6fa 0%, #e8edf6 100%); /* FF3.6+ */ >+ background: -webkit-gradient(linear, left top, left bottom, color-stop(0%,#f4f6fa), color-stop(100%,#e8edf6)); /* Chrome,Safari4+ */ >+ background: -webkit-linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* Chrome10+,Safari5.1+ */ >+ background: -o-linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* Opera11.10+ */ >+ background: -ms-linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* IE10+ */ >+ filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#f4f6fa', endColorstr='#e8edf6',GradientType=0 ); /* IE6-9 */ >+ background: linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* W3C */ >+ border : 1px solid #BCBCBC; >+ padding : .5em; >+ margin : .5em 0; > } >- >+ >+div.note i.fa-exclamation { >+ color: #cc0000; >+ font-style: italic; >+ padding: 0 0.3em; >+} >+ > div.results { > padding : .7em 0; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >index d3a5f20..293a379 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >@@ -74,7 +74,7 @@ $(document).ready(function() { > [% IF ( action_add_category ) %]New category[% END %] > </h1> > >- [% IF ( action_modify ) %]<div class="note"><strong>NOTE:</strong> If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately.</div>[% END %] >+ [% IF ( action_modify ) %]<div class="note"><i class="fa fa-exclamation"></i> <strong>NOTE:</strong> If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately.</div>[% END %] > > <form action="/cgi-bin/koha/admin/authorised_values.pl" name="Aform" method="post"> > <input type="hidden" name="op" value="add" /> >@@ -167,7 +167,7 @@ $(document).ready(function() { > </div> > > <h1>Authorized values</h1> >-<div class="note"><strong>NOTE:</strong> If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately.</div> >+<div class="note"><i class="fa fa-exclamation"></i> <strong>NOTE:</strong> If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately.</div> > > [% FOR m IN messages %] > <div class="dialog [% m.type %]"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >index 182cc8b..9df964b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt >@@ -175,7 +175,7 @@ $(document).ready(function() { > [% END %] > </tbody> > </table> >- <div class="note">Reminder: this action will delete all selected bibliographic records, attached subscriptions, existing holds, and attached items!</div> >+ <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will delete all selected bibliographic records, attached subscriptions, existing holds, and attached items!</div> > [% ELSE %] > <div id="toolbar"> > <a id="selectall" href="#">Select all</a> >@@ -203,7 +203,7 @@ $(document).ready(function() { > [% END %] > </tbody> > </table> >- <div class="note">Reminder: this action will delete all selected authorities!</div> >+ <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will delete all selected authorities!</div> > [% END %] > <fieldset class="action"> > <input type="hidden" name="op" value="delete" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt >index ea00c36..1d95ef7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt >@@ -215,7 +215,7 @@ $(document).ready(function() { > [% END %] > </tbody> > </table> >- <div class="note">Reminder: this action will modify all selected biblios!</div> >+ <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will modify all selected biblios!</div> > [% ELSE %] > <div id="toolbar"> > <a id="selectall" href="#">Select all</a> >@@ -241,7 +241,7 @@ $(document).ready(function() { > [% END %] > </tbody> > </table> >- <div class="note">Reminder: this action will modify all selected authorities!</div> >+ <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will modify all selected authorities!</div> > [% END %] > <fieldset class="action"> > <input type="hidden" name="op" value="modify" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/img/note.png b/koha-tmpl/intranet-tmpl/prog/img/note.png >deleted file mode 100644 >index 5c3f8b6a5665888dabb6a8e442b622d40a77eb53..0000000000000000000000000000000000000000 >GIT binary patch >literal 0 >KcmV+b0RR6000031 > >literal 511 >zcmV<b0RaAqP)<h;3K|Lk000e1NJLTq000sI000sQ0{{R3VGw?000004XF*Lt006JZ >zHwB960000PbVXQnQ*UN;cVTj606}DLVr3vnZDD6+Qe|Oed2z{QJOBUyoKQ?uMZFFV >z*OZyP5fQ;AC%q65<JH{b*4^dZ<h~UZ=H%?aA0O!J^X1;<zZn|QcYE5WtmfkCyb225 >zyTZ?FZ|Car(RqE)aC6<az1_07z7`k7Iy=7>7RNwC<ksHIU0}Wv64Zu@=H>0$rK;43 >zjL>v<<>2VpnVsRw(%i1J(tUxy9UkP@-{jcey$=t*5D@3)?%156y9Nd5?DXjE_3Ni> >zMF0Q*G;~r<Q~&?}|NsC0|NsC0|NsC0|NsC0|NsC0|NsC0|NsC0|NsC0|NsC0|NsC0 >z|NsC0|NsC0083XQWdHyGsYygZRCwBAFvb7?0mOhQ1Q0+7A$CSl2}KYCAb{XPBFY?0 >z%<3Q(KmZ|Bspv7tu!0x>0fZ2eVv#ohGXMezAtb3Q24MgM5L`%rL0TKa0tg_ukT?UM >z5rhR0KyV=qE>$QCAb{XPI+`#RKmfsoWI16hfB=FDu_-We!-N0=2r4AZtHlo!0tg_e >zker~Q5=;mnfS^J=YC`%jA%FnF5;y<>ghdD-zyRvzI>!hjq!<7I002ovPDHLkV1k4~ >B>B|5B > >-- >2.7.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16032
:
48895
|
49226
| 49248