Bugzilla – Attachment 49267 Details for
Bug 16047
Software error on deleting a group with no category code
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16047 [Follow-up] Software error on deleting a group with no category code
Bug-16047-Follow-up-Software-error-on-deleting-a-g.patch (text/plain), 3.51 KB, created by
Owen Leonard
on 2016-03-17 13:16:06 UTC
(
hide
)
Description:
Bug 16047 [Follow-up] Software error on deleting a group with no category code
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2016-03-17 13:16:06 UTC
Size:
3.51 KB
patch
obsolete
>From 4e5036365f63f1dcbb9c9e13e2ac21b5a19a33a2 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 17 Mar 2016 09:08:39 -0400 >Subject: [PATCH] Bug 16047 [Follow-up] Software error on deleting a group with > no category code >Content-Type: text/plain; charset="utf-8" > >This follow-up take the original patch a little further, making category >name required on the entry form as well. Without a category name there >is no label in the interface when selecting a category. That doens't >make any sense. > >Also changed on the group entry form: > >- Added "required" attribute to labels on required fields. >- Changed "Update" submit button label to "Submit." >- Added a "Cancel" link. >- Added the "validated" class to the form so that our built-in > validation script will process it (not strictly necessary but makes > the validation appearance more consistent). >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >index 097cac5..9c34ee0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >@@ -329,7 +329,7 @@ tinyMCE.init({ > > [% IF op == 'add_form_category' %] > <h3>[% IF category.categorycode %]Edit group [% category.categorycode %][% ELSE %]Add group[% END %]</h3> >- <form action="/cgi-bin/koha/admin/branches.pl" name="Aform" method="post"> >+ <form action="/cgi-bin/koha/admin/branches.pl" name="Aform" method="post" class="validated"> > <input type="hidden" name="op" value="add_validate_category" /> > [% IF category.categorycode %] > <input type="hidden" name="is_a_modif" value="1" /> >@@ -342,14 +342,15 @@ tinyMCE.init({ > <input type="hidden" name="categorycode" id="categorycode" value="[% category.categorycode |html %]" /> > [% category.categorycode %] > [% ELSE %] >- <label for="categorycode">Category code:</label> >+ <label for="categorycode" class="required">Category code:</label> > <input type="text" name="categorycode" id="categorycode" size="10" maxlength="10" class="required" required="required" /> > <span class="required">Required</span> > [% END %] > </li> > <li> >- <label for="categoryname">Name: </label> >- <input type="text" name="categoryname" id="categoryname" size="32" maxlength="32" value="[% category.categoryname |html %]" /> >+ <label for="categoryname" class="required">Name: </label> >+ <input type="text" name="categoryname" id="categoryname" size="32" maxlength="32" value="[% category.categoryname |html %]" class="required" required="required" /> >+ <span class="required">Required</span> > </li> > <li> > <label for="codedescription">Description: </label> >@@ -378,7 +379,10 @@ tinyMCE.init({ > </li> > </ol> > </fieldset> >- <fieldset class="action"><input type="submit" value="Update" /></fieldset> >+ <fieldset class="action"> >+ <input type="submit" value="Submit" /> >+ <a href="/cgi-bin/koha/admin/branches.pl" class="cancel">Cancel</a> >+ </fieldset> > </form> > [% END %] > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16047
:
48978
|
49266
|
49267
|
49268
|
49348
|
49349