Bugzilla – Attachment 49336 Details for
Bug 15868
Ask for confirmation before deleting MARC modification template action
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15868: Ask for confirmation when deleting a MMT action
PASSED-QA-Bug-15868-Ask-for-confirmation-when-dele.patch (text/plain), 3.40 KB, created by
Katrin Fischer
on 2016-03-20 17:17:34 UTC
(
hide
)
Description:
[PASSED QA] Bug 15868: Ask for confirmation when deleting a MMT action
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-03-20 17:17:34 UTC
Size:
3.40 KB
patch
obsolete
>From cf8c3a804acd585468350ea26833cde130f511b2 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 8 Mar 2016 11:07:43 +0000 >Subject: [PATCH] [PASSED QA] Bug 15868: Ask for confirmation when deleting a > MMT action > >Test plan: >Create marc modification template >Add an action >Delete it >With this patch you must get a confirmation mesg > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/js/marc_modification_templates.js | 9 ++++++--- > .../prog/en/modules/tools/marc_modification_templates.tt | 5 +++-- > 2 files changed, 9 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/marc_modification_templates.js b/koha-tmpl/intranet-tmpl/prog/en/js/marc_modification_templates.js >index 185afa8..9353637 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/marc_modification_templates.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/marc_modification_templates.js >@@ -185,9 +185,12 @@ function clearFormElements(divId) { > > } > >+function confirmDeleteAction() { >+ return confirm( MSG_MMT_CONFIRM_DEL_TEMPLATE_ACTION ); >+} >+ > function confirmDelete() { >- var agree = confirm( MSG_MMT_CONFIRM_DEL_TEMPLATE ); >- return agree; >+ return confirm( MSG_MMT_CONFIRM_DEL_TEMPLATE ); > } > > var modaction_legend_innerhtml; >@@ -285,4 +288,4 @@ function setSelectByValue( selectId, value ) { > s.selectedIndex = i; > } > } >-} >\ No newline at end of file >+} >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >index e621de2..1086670 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >@@ -11,7 +11,8 @@ > var MSG_MMT_SOURCE_FIELD = _("The source field should be filled."); > var MSG_MMT_EVERY = _("Every"); > var MSG_MMT_ALL = _("All"); >- var MSG_MMT_CONFIRM_DEL_TEMPLATE= _("Are you sure you wish to delete this template?"); >+ var MSG_MMT_CONFIRM_DEL_TEMPLATE = _("Are you sure you wish to delete this template?"); >+ var MSG_MMT_CONFIRM_DEL_TEMPLATE_ACTION = _("Are you sure you wish to delete this template action?"); > var MSG_MMT_EDIT_ACTION = _("Edit action %s"); > var MSG_MMT_UPDATE_ACTION = _("Update action"); > //]]> >@@ -162,7 +163,7 @@ > "[% ActionsLoo.conditional_regex |replace('\\\\', '\\\\') |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]", > "[% ActionsLoo.description |replace('\\\\', '\\\\') |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]" > );updateAllEvery();'>Edit</a></td> >- <td><a href="marc_modification_templates.pl?template_id=[% ActionsLoo.template_id %]&op=delete_action&mmta_id=[% ActionsLoo.mmta_id %]">Delete</a></td> >+ <td><a href="marc_modification_templates.pl?template_id=[% ActionsLoo.template_id %]&op=delete_action&mmta_id=[% ActionsLoo.mmta_id %]" onclick="return confirmDeleteAction();">Delete</a></td> > </tr> > [% END %] > </table> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15868
:
48775
|
48787
| 49336 |
50010