From 4b5eeaef19d43ac55f2a79bcef8e5e0dfde3d4b6 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 23 Mar 2016 16:59:02 +0000 Subject: [PATCH] [PASSED QA] Bug 16007: Simplify the DB entry - No need to check if the table exists - No need to check if the column exists, just remove the warning Signed-off-by: Katrin Fischer --- ...ck_into_table_overduerules_transport_types.perl | 41 ++++------------------ 1 file changed, 6 insertions(+), 35 deletions(-) diff --git a/installer/data/mysql/atomicupdate/Bug_16007_adding_column_letternumber_back_into_table_overduerules_transport_types.perl b/installer/data/mysql/atomicupdate/Bug_16007_adding_column_letternumber_back_into_table_overduerules_transport_types.perl index 71a1dc2..dc8e211 100755 --- a/installer/data/mysql/atomicupdate/Bug_16007_adding_column_letternumber_back_into_table_overduerules_transport_types.perl +++ b/installer/data/mysql/atomicupdate/Bug_16007_adding_column_letternumber_back_into_table_overduerules_transport_types.perl @@ -1,36 +1,7 @@ -#!/usr/bin/perl - -use strict; -use warnings; - -use C4::Context; -use C4::Members; - my $dbh = C4::Context->dbh; -my $sth = $dbh->prepare("SELECT * FROM overduerules_transport_types WHERE 0 = 1"); -my $urv = $sth->execute(); - -my @data; - -if ( $sth->{NUM_OF_FIELDS} > 0 ) -{ - @data = @{$sth->{NAME}}; - - my @letternumber = grep { $_ eq 'letternumber' } @data; - - if ( ! @letternumber ) - { - my $urv = $dbh->do("ALTER TABLE overduerules_transport_types ADD COLUMN letternumber INT(1) NOT NULL DEFAULT 1 AFTER id"); - print "Bug 16007: adding column 'letternumber' back into table 'overduerules_transport_types'\n"; - } - else - { - print "Bug 16007: your table 'overduerules_transport_types' already has a column 'letternumber'; nothing to do\n"; - } -} -else -{ - # table overduerules_transport_types should exist by now, but let's - # warn the user here just in case - print "Bug 16007: [ERROR] your table 'overduerules_transport_types' does not exists ?!\n"; -} +my ($print_error) = $dbh->{PrintError}; +$dbh->{RaiseError} = 0; +$dbh->{PrintError} = 0; +$dbh->do("ALTER TABLE overduerules_transport_types ADD COLUMN letternumber INT(1) NOT NULL DEFAULT 1 AFTER id"); +$dbh->{PrintError} = $print_error; +print "Bug 16007: Make sure overduerules_transport_types.letternumber exists\n"; -- 1.9.1