From 07f2935e70d32d25e1fc7932d490ca9bd5a8d650 Mon Sep 17 00:00:00 2001
From: Aleisha <aleishaamohia@hotmail.com>
Date: Wed, 23 Mar 2016 21:53:44 +0000
Subject: [PATCH] Bug 15793 - UX of circulation patron search with long lists
 of returned borrowers
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Okay how about this:
This patch has no floating toolbar or names styled as links. I've removed the radio buttons. The row is clickable and will redirect you to the user's page.

To test:
1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a')
2) Select a patron by clicking anywhere on the row - confirm you are taken to the correct patron page

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron <veron@veron.ch>
---
 .../intranet-tmpl/prog/en/modules/circ/circulation.tt    |   14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
index 3bfc7fe..7d38c0c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ -28,7 +28,6 @@
 <script type="text/javascript" src="[% themelang %]/js/pages/circulation.js"></script>
 <script type="text/javascript" src="[% themelang %]/js/checkouts.js"></script>
 <script type="text/javascript" src="[% themelang %]/js/holds.js"></script>
-<script type="text/javascript" src="[% interface %]/lib/jquery/plugins/jquery.fixFloat.js"></script>
 <script type="text/javascript">
 //<![CDATA[
 /* Set some variable needed in circulation.js */
@@ -90,7 +89,9 @@ $(document).ready(function() {
         }
     });
 
-    $("#selecttoolbar").fixFloat();
+    $(".clickable").click(function() {
+        window.document.location = $(this).data('url');
+    });
 
     [% IF !( CircAutoPrintQuickSlip == 'clear' ) %]
         // listen submit to trigger qslip on empty checkout
@@ -572,15 +573,9 @@ No patron matched <span class="ex">[% message %]</span>
     <input type="hidden" name="duedatespec" value="[% duedatespec %]" />
     <input type="hidden" name="stickyduedate" value="[% stickyduedate %]" />
 
-<div id="selecttoolbar" class="btn-toolbar">
-    <fieldset class="action"><button type="submit" class="btn btn-small"><i class="fa fa-check"></i> Select patron</button></fieldset>
-</div>
-
-
     <table id="table_borrowers">
         <thead>
             <tr>
-                <th></th>
                 <th>Name</th>
                 <th>Cardnumber</th>
                 <th>Category</th>
@@ -590,8 +585,7 @@ No patron matched <span class="ex">[% message %]</span>
         </thead>
         <tbody>
             [% FOREACH borrower IN borrowers %]
-            <tr>
-                <td><input type="radio" name="borrowernumber" value="[% borrower.borrowernumber %]" /></td>
+            <tr class="clickable" data-url="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% borrower.borrowernumber %]">
                 <td>[% borrower.surname %], [% borrower.firstname %]</td>
                 <td>[% borrower.cardnumber %]</td>
                 <td>[% borrower.categorycode %]</td>
-- 
1.7.10.4