@@ -, +, @@
- t/db_dependent/ILSDI_Services.t was failing for me as I had
issues in my database, fixed with another delete line
- QA tools found a typo - comparision
- Added documentation of the new parameter to the ilsdi.pl page
---
koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt | 2 ++
t/db_dependent/ILSDI_Services.t | 5 +++--
2 files changed, 5 insertions(+), 2 deletions(-)
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
+++ a/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
@@ -514,6 +514,8 @@
whether or not to return hold request information in the response
show_loans (Optional, default 0)
whether or not to return loan information in the response
+ show_attributes (Optional, default 0)
+ whether or not to return extended patron attributes information in the response
Example call
--- a/t/db_dependent/ILSDI_Services.t
+++ a/t/db_dependent/ILSDI_Services.t
@@ -100,6 +100,7 @@ $dbh->{RaiseError} = 0;
my $schema = Koha::Database->schema;
$schema->storage->txn_begin;
+$schema->resultset( 'Issue' )->delete_all;
$schema->resultset( 'Borrower' )->delete_all;
$schema->resultset( 'BorrowerAttribute' )->delete_all;
$schema->resultset( 'BorrowerAttributeType' )->delete_all;
@@ -180,7 +181,7 @@ $schema->resultset( 'Branch' )->delete_all;
my $reply = C4::ILSDI::Services::GetPatronInfo( $query );
- # Build a structure for comparision:
+ # Build a structure for comparison:
my $cmp = {
category_code => $attr_type->{'category_code'},
class => $attr_type->{'class'},
@@ -193,7 +194,7 @@ $schema->resultset( 'Branch' )->delete_all;
};
# Check results:
- is_deeply( $reply->{'attributes'}, [ $cmp ] );
+ is_deeply( $reply->{'attributes'}, [ $cmp ], 'Test GetPatronInfo - show_attributes parameter' );
}
# Cleanup
--