From 5319536bc3b13264749a8cde34aa634408834809 Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Wed, 30 Mar 2016 08:12:56 +0200 Subject: [PATCH] Bug 14257: Follow-up - Add documentation, fix typo, fix test - t/db_dependent/ILSDI_Services.t was failing for me as I had issues in my database, fixed with another delete line - QA tools found a typo - comparision - Added documentation of the new parameter to the ilsdi.pl page --- koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt | 2 ++ t/db_dependent/ILSDI_Services.t | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt index e6544cc..993af71 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt @@ -514,6 +514,8 @@
whether or not to return hold request information in the response
show_loans (Optional, default 0)
whether or not to return loan information in the response
+
show_attributes (Optional, default 0)
+
whether or not to return extended patron attributes information in the response

Example call

diff --git a/t/db_dependent/ILSDI_Services.t b/t/db_dependent/ILSDI_Services.t index 73313bf..ee012e2 100644 --- a/t/db_dependent/ILSDI_Services.t +++ b/t/db_dependent/ILSDI_Services.t @@ -100,6 +100,7 @@ $dbh->{RaiseError} = 0; my $schema = Koha::Database->schema; $schema->storage->txn_begin; +$schema->resultset( 'Issue' )->delete_all; $schema->resultset( 'Borrower' )->delete_all; $schema->resultset( 'BorrowerAttribute' )->delete_all; $schema->resultset( 'BorrowerAttributeType' )->delete_all; @@ -180,7 +181,7 @@ $schema->resultset( 'Branch' )->delete_all; my $reply = C4::ILSDI::Services::GetPatronInfo( $query ); - # Build a structure for comparision: + # Build a structure for comparison: my $cmp = { category_code => $attr_type->{'category_code'}, class => $attr_type->{'class'}, @@ -193,7 +194,7 @@ $schema->resultset( 'Branch' )->delete_all; }; # Check results: - is_deeply( $reply->{'attributes'}, [ $cmp ] ); + is_deeply( $reply->{'attributes'}, [ $cmp ], 'Test GetPatronInfo - show_attributes parameter' ); } # Cleanup -- 1.9.1