Bugzilla – Attachment 49710 Details for
Bug 16161
Add confirm message when deleting dictionary definition
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16161: Confirm message when deleting definition
Bug-16161-Confirm-message-when-deleting-definition.patch (text/plain), 1.83 KB, created by
Mark Tompsett
on 2016-03-31 01:48:21 UTC
(
hide
)
Description:
Bug 16161: Confirm message when deleting definition
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2016-03-31 01:48:21 UTC
Size:
1.83 KB
patch
obsolete
>From a3dfd1052be33b91222aa21540bca57ed5759012 Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Tue, 29 Mar 2016 23:37:19 +0000 >Subject: [PATCH] Bug 16161: Confirm message when deleting definition > >To test: > >1) Go to Reports -> View dictionary >2) Attempt to delete definiton. Confirm that a confirm messages comes up and works as expected. > >Sponsored-by: Catalyst IT > >NOTE: confirmation message didn't exist before patch. > confirmation message appeared after patch. > both options worked as expected. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >index 30be1ed..ed3f21b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt >@@ -3,6 +3,9 @@ > [% INCLUDE 'doc-head-close.inc' %] > [% INCLUDE 'calendar.inc' %] > <style type="text/css">fieldset.rows table { clear: none; margin: 0;}</style> >+<script type="text/javascript"> >+var MSG_CONFIRM_DELETE = _("Are you sure you want to delete this dictionary definition? This cannot be undone."); >+</script> > </head> > <body id="rep_dictionary" class="rep"> > [% INCLUDE 'header.inc' %] >@@ -79,7 +82,7 @@ > <td><form method="post" action="/cgi-bin/koha/reports/dictionary.pl"> > <input type="hidden" name="id" value="[% definition.id %]" /> > <input type="hidden" name="phase" value="Delete Definition" /> >- <input type="submit" name="submit" value="Delete Definition" /> >+ <input type="submit" name="submit" value="Delete Definition" onclick="return confirm(MSG_CONFIRM_DELETE);" /> > </form></td> > </tr> > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16161
:
49660
|
49710
|
49818