Bugzilla – Attachment 49742 Details for
Bug 16103
Remove FK constraint for sms_provider_id in deletedborrowers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16103: Remove FK sms_provider_id in deletedborrowers
Bug-16103-Remove-FK-smsproviderid-in-deletedborrow.patch (text/plain), 1.96 KB, created by
Tomás Cohen Arazi
on 2016-03-31 18:06:05 UTC
(
hide
)
Description:
Bug 16103: Remove FK sms_provider_id in deletedborrowers
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2016-03-31 18:06:05 UTC
Size:
1.96 KB
patch
obsolete
>From f6518f66c5c32a773a3c8a15c3bc4ce2645b7d92 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 18 Mar 2016 14:11:11 +0100 >Subject: [PATCH] Bug 16103: Remove FK sms_provider_id in deletedborrowers > >This patch removes the FK constraint for sms_provider_id in table >deletedborrowers. (We do not need FKs in that table.) >It just corrects a newly added db revision in updatedatabase. >If this is pushed before releasing master, no need to do anything more. > >Note that this key was not found in kohastructure and the DBIx schema. > >Edit: > >To test: >- With master DB run > $ prove t/db_dependent/TestBuilder.t >=> SUCCESS: Tests pass >- Create a clean 3.22.00 DB >- Run the upgrade process > $ perl installer/data/mysql/updatedatabase.pl >- Run > $ prove t/db_dependent/TestBuilder.t >=> FAIL: Tests fail due to discrepancies in DB structure >- Re-create teh clean 3.22.00 DB >- Apply the patch >- Run the upgrade process > $ perl installer/data/mysql/updatedatabase.pl >- Run > $ prove t/db_dependent/TestBuilder.t >=> SUCCESS: Tests now pass > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > installer/data/mysql/updatedatabase.pl | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index cbad1fe..137ae6c 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -11755,9 +11755,6 @@ if ( CheckVersion($DBversion) ) { > $dbh->do(q{ > ALTER TABLE deletedborrowers ADD sms_provider_id INT( 11 ) NULL DEFAULT NULL AFTER smsalertnumber; > }); >- $dbh->do(q{ >- ALTER TABLE deletedborrowers ADD FOREIGN KEY ( sms_provider_id ) REFERENCES sms_providers ( id ) ON UPDATE CASCADE ON DELETE SET NULL; >- }); > > print "Upgrade to $DBversion done (Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send drivers)\n"; > SetVersion($DBversion); >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16103
:
49312
| 49742