Bugzilla – Attachment 49820 Details for
Bug 1750
Report bor_issues_top erroneous and truncated results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 1750 - Report bor_issues_top erroneous and truncated results.
PASSED-QA-Bug-1750---Report-borissuestop-erroneous.patch (text/plain), 1.60 KB, created by
Katrin Fischer
on 2016-04-03 12:57:49 UTC
(
hide
)
Description:
[PASSED QA] Bug 1750 - Report bor_issues_top erroneous and truncated results.
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-04-03 12:57:49 UTC
Size:
1.60 KB
patch
obsolete
>From 499cf4da81c402a21123a2f76a875232d28be0e4 Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Fri, 1 Apr 2016 15:23:22 +1300 >Subject: [PATCH] [PASSED QA] Bug 1750 - Report bor_issues_top erroneous and > truncated results. > >Signed-off-by: Mason James <mtj@kohaaloha.com> > >TEST PLAN >--------- >1) Ensure you have some checkouts >2) Home -> Reports > -> Patrons with the most checkouts >3) Click 'Submit' > -- you get a list >4) Click a patron name. >5) Note the borrower number. >6) In MySQL run something like: > > UPDATE borrower SET firstname=NULL WHERE borrowernumber=#### >7) Refresh the report page > -- name goes totally blank >8) apply patch >9) Refresh the report page > -- only first name is lost >10) run koha qa test tools > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > reports/bor_issues_top.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reports/bor_issues_top.pl b/reports/bor_issues_top.pl >index e230a10..8253fee 100755 >--- a/reports/bor_issues_top.pl >+++ b/reports/bor_issues_top.pl >@@ -279,7 +279,7 @@ sub calculate { > my $strcalc ; > > # Processing average loanperiods >- $strcalc .= "SELECT CONCAT(borrowers.surname , \",\\t\",borrowers.firstname), COUNT(*) AS RANK, borrowers.borrowernumber AS ID"; >+ $strcalc .= "SELECT CONCAT_WS('', borrowers.surname , \",\\t\", borrowers.firstname), COUNT(*) AS RANK, borrowers.borrowernumber AS ID"; > $strcalc .= " , $colfield " if ($colfield); > $strcalc .= " FROM `old_issues` > LEFT JOIN borrowers USING(borrowernumber) >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 1750
:
49758
|
49759
|
49762
|
49763
| 49820