Bugzilla – Attachment 49827 Details for
Bug 16104
Warnings "used only once: possible typo" should be removed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 16104: Remove warnings "used only once: possible typo"
PASSED-QA-Bug-16104-Remove-warnings-used-only-once.patch (text/plain), 1.68 KB, created by
Katrin Fischer
on 2016-04-03 15:07:28 UTC
(
hide
)
Description:
[PASSED QA] Bug 16104: Remove warnings "used only once: possible typo"
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-04-03 15:07:28 UTC
Size:
1.68 KB
patch
obsolete
>From c83300030889d4a917e821537149dbbcfa07f55c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 18 Mar 2016 13:31:27 +0000 >Subject: [PATCH] [PASSED QA] Bug 16104: Remove warnings "used only once: > possible typo" > >Since bug 11998, the following warnings are raised: >Name "Tie::Hash::FIELDS" used only once: possible typo at /usr/share/perl/5.22/fields.pm line 135. >Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at /usr/share/perl/5.22/fields.pm line 135. >Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo at /usr/share/perl/5.22/fields.pm line 135. > >It comes from the Koha::Cache > >103 if ( can_load( modules => { 'Cache::Memory' => undef } ) ) { > >Test plan: > perl -wc C4/AuthoritiesMarc.pm >should return green > >QA note: this may have an impact on performance but I have not found any other workarounds. > >NOTE: I applied 15870 to master, got the error (-v 2 -c 5), applied 16104, >rebased it in front, error disappeared (still only -c 5), rebased it at the end, >and signed off 16104. > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > Koha/Cache.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Cache.pm b/Koha/Cache.pm >index 8370d3e..4e45180 100644 >--- a/Koha/Cache.pm >+++ b/Koha/Cache.pm >@@ -103,7 +103,7 @@ sub new { > } > } > >- if ( can_load( modules => { 'Cache::Memory' => undef } ) ) { >+ if ( can_load( modules => { 'Cache::Memory' => undef, nocache => 1 } ) ) { > _initialize_memory($self); > if ( $self->{'default_type'} eq 'memory' > && defined( $self->{'memory_cache'} ) ) >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16104
:
49314
|
49325
|
49827
|
51087
|
51088