From c5f88b75e89d492436487efe982fd93059a90028 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 15 Aug 2013 14:53:26 -0400 Subject: [PATCH] [PASSED QA] Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, tried adding one, one & dup, multiple and cancel multiple No errors Signed-off-by: Katrin Fischer --- .../prog/en/modules/cataloguing/additem.tt | 36 +++++++++++++++++----- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt index 1de8960..5ef7851 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt @@ -62,7 +62,24 @@ $(document).ready(function(){ "bKohaColumnsUseNames": true }, columns_settings); + var multiCopyControl = $("#add_multiple_copies_span"); + var addMultipleBlock = $("#addmultiple"); + var addSingleBlock = $("#addsingle"); + multiCopyControl.hide(); + $("#add_multiple_copies").on("click",function(e){ + e.preventDefault; + addMultipleBlock.toggle(); + addSingleBlock.toggle(); + multiCopyControl.toggle(); + }); + $("#cancel_add_multiple").on("click",function(e){ + e.preventDefault(); + addMultipleBlock.toggle(); + addSingleBlock.toggle(); + multiCopyControl.toggle(); + }); }); + function Check(f) { var total_errors = CheckMandatorySubfields(f); if (total_errors==0) { @@ -288,14 +305,19 @@ function confirm_deletion() { when pressing the enter key, while in fact it is the first submit button that is validated, in our case the "add (single) item" button. It is a bit tricky, but necessary in the sake of UI correctness. --> - - - -