Bugzilla – Attachment 49960 Details for
Bug 14816
Item search returns no results with multiple values selected for one field
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 14816: Fix multiple selection in item search
SIGNED-OFF-Bug-14816-Fix-multiple-selection-in-ite.patch (text/plain), 1.78 KB, created by
Owen Leonard
on 2016-04-06 13:02:13 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 14816: Fix multiple selection in item search
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2016-04-06 13:02:13 UTC
Size:
1.78 KB
patch
obsolete
>From 2d1b581ceb974cb972ca567888108bd02c1d9301 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Thu, 7 Jan 2016 15:38:57 +0100 >Subject: [PATCH] [SIGNED-OFF] Bug 14816: Fix multiple selection in item search >Content-Type: text/plain; charset="utf-8" > >Send each selected value as a separate parameter. Otherwise DataTables >(or jQuery ?) joins all values with a comma > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >I could not reproduce the bug when selecting multiple home libraries, >but I could by selecting multiple item types or collection codes. The >patch allowed those queries to complete correctly. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >index 15cbb91..09e6b84 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >@@ -230,7 +230,12 @@ > $('#results-wrapper').empty().html(results_heading + table); > > var params = []; >- $form.find('select,input[type="text"],input[type="hidden"]').not('[disabled]').each(function () { >+ $form.find('select').not('[disabled]').find('option:selected').each(function () { >+ var name = $(this).parent('select').attr('name'); >+ var value = $(this).val(); >+ params.push({ 'name': name, 'value': value }); >+ }); >+ $form.find('input[type="text"],input[type="hidden"]').not('[disabled]').each(function () { > params.push({ 'name': $(this).attr('name'), 'value': $(this).val() }); > }); > $form.find('input[type="radio"]:checked').each(function() { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14816
:
46395
|
46436
|
46504
|
49952
|
49960
|
49977