From c0310a92d97592184707cae1c4c85469f7adce8a Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 8 Apr 2016 14:46:21 -0400 Subject: [PATCH] Bug 16231 - Correct permission handling in subscription edit menu MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch corrects the way subscription edit menu items are displayed according to the user's permissions settings. The edit menu has been updated to use the menu item terms "Edit," "Duplicate," and "Delete" instead of "Edit subscription," "Edit as new (duplicate)", and "Delete subscription. The change makes the terms less redundant and more consistent with other similar menus in Koha. Font Awesome icons have been added to each menu item. This patch also removes a non-standard "fa-lg" class from some Font Awesome icons in the toolbar. To test, apply the patch and log in to the staff client as a user who has permission to create, edit, and delete subscriptions. - Locate an subscription and view the details for it. - The "Edit" menu should show three options: "Edit," "Duplicate," and "Delete." - Confirm that each menu item works correctly. - Repeat the process when logged in as a user with varying combinations of create, edit, and delete permissions. Followed test plan, works as expected. Signed-off-by: Marc VĂ©ron --- .../prog/en/includes/serials-toolbar.inc | 31 ++++++++++++-------- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc index 2581be2..b79dd45 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc @@ -39,9 +39,9 @@
[% IF CAN_user_serials_create_subscription %] [% IF biblionumber_for_new_subscription %] - + [% ELSE %] - + [% END %] [% END %] @@ -50,16 +50,21 @@
[% END %] @@ -84,9 +89,9 @@ [% ELSIF CAN_user_serials_create_subscription %]
[% IF ( biblionumber_for_new_subscription ) %] - + [% ELSE %] - + [% END %]
[% END %] -- 1.7.10.4