Bugzilla – Attachment 50238 Details for
Bug 16229
Koha::Cache should be on the safe side
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16229: (QA) POD fixes
Bug-16229-QA-POD-fixes.patch (text/plain), 1.97 KB, created by
Tomás Cohen Arazi (tcohen)
on 2016-04-14 13:52:13 UTC
(
hide
)
Description:
Bug 16229: (QA) POD fixes
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2016-04-14 13:52:13 UTC
Size:
1.97 KB
patch
obsolete
>From 22345ab7d3834105e1b7e53bfac398a56d20bd49 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@unc.edu.ar> >Date: Thu, 14 Apr 2016 10:47:31 -0300 >Subject: [PATCH] Bug 16229: (QA) POD fixes > >Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> >--- > Koha/Cache.pm | 31 ++++++++++++++++++++++--------- > 1 file changed, 22 insertions(+), 9 deletions(-) > >diff --git a/Koha/Cache.pm b/Koha/Cache.pm >index 7e8970d..02a4712 100644 >--- a/Koha/Cache.pm >+++ b/Koha/Cache.pm >@@ -242,12 +242,12 @@ The possible options are: > > Expiry time of this cached entry in seconds. > >-=item deepcopy >+=item unsafe > >-If set, this will perform a deep copy of the item when it's retrieved. This >-means that it'll be safe if something later modifies the result of the >-function. Will be ignored in situations where the same behaviour comes from >-the caching layer anyway. >+If set, this will avoid performing a deep copy of the item. This >+means that it won't be safe if something later modifies the result of the >+function. It should be used with caution, and could save processing time >+in some situations where is safe to use it. > > =item cache > >@@ -307,10 +307,23 @@ sub set_in_cache { > > Retrieve the value stored under the specified key in the default cache. > >-The options can set an unsafe flag to avoid a deep copy. >-When this flag is set, you have to know what you are doing! >-If you are retrieving a structure and modify it, you will modify the contain >-of the cache! >+The possible options are: >+ >+=over >+ >+=item unsafe >+ >+If set, this will avoid performing a deep copy of the item. This >+means that it won't be safe if something later modifies the result of the >+function. It should be used with caution, and could save processing time >+in some situations where is safe to use it. Make sure you know what you are doing! >+ >+=item cache >+ >+The cache object to use if you want to provide your own. It should be an >+instance of C<Cache::*> and follow the same interface as L<Cache::Memcache>. >+ >+=back > > =cut > >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16229
:
50072
|
50073
|
50074
|
50076
|
50199
|
50200
|
50201
|
50235
|
50236
|
50237
| 50238