Bugzilla – Attachment 50253 Details for
Bug 16268
Add confirm message when deleting circ and fines rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16268: Add confirm message for deleting circ and fines rules
Bug-16268-Add-confirm-message-for-deleting-circ-an.patch (text/plain), 4.49 KB, created by
Aleisha Amohia
on 2016-04-14 23:00:58 UTC
(
hide
)
Description:
Bug 16268: Add confirm message for deleting circ and fines rules
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2016-04-14 23:00:58 UTC
Size:
4.49 KB
patch
obsolete
>From 4e8a2e6c31d1deeb1a0356d3e4842640106cc4c6 Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Thu, 14 Apr 2016 22:59:20 +0000 >Subject: [PATCH] Bug 16268: Add confirm message for deleting circ and fines > rules > >To test: >1) Apply 16267 >2) Go to Admin -> Circ and fines rules >3) Try clicking on Delete and Unset buttons >4) Confirm a confirm message pops up and works as expected > >Sponsored-by: Catalyst IT >--- > .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index 13ec6d2..6cb1afa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -5,6 +5,9 @@ > <script type="text/javascript"> > //<![CDATA[ > >+var MSG_CONFIRM_UNSET = _("Are you sure you want to unset this rule?"); >+var MSG_CONFIRM_DELETE = _("Are you sure you want to delete this rule? This cannot be undone."); >+ > function clear_edit(){ > var cancel = confirm(_("Are you sure you want to cancel your changes?")); > if ( !cancel ) return; >@@ -253,7 +256,7 @@ for="tobranch"><strong>Clone these rules to:</strong></label> <input type="hidde > <td>[% rule.rentaldiscount %]</td> > <td class="actions"> > <a href="#" class="editrule btn btn-mini"><i class="fa fa-pencil"></i> Edit</a> >- <a class="btn btn-mini" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete&itemtype=[% rule.itemtype %]&categorycode=[% rule.categorycode %]&branch=[% rule.current_branch %]"><i class="fa fa-trash"></i> Delete</a> >+ <a class="btn btn-mini" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete&itemtype=[% rule.itemtype %]&categorycode=[% rule.categorycode %]&branch=[% rule.current_branch %]" onclick="return confirm(MSG_CONFIRM_DELETE);"><i class="fa fa-trash"></i> Delete</a> > </td> > </tr> > [% END %] >@@ -438,7 +441,7 @@ for="tobranch"><strong>Clone these rules to:</strong></label> <input type="hidde > </td> > <td class="actions"> > <button type="submit" class="btn btn-mini"><i class="fa fa-save"></i> Save</button> >- <a class="btn btn-mini" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete-branch-cat&categorycode=*&branch=[% current_branch %]"><i class="fa fa-undo"></i> Unset</a> >+ <a class="btn btn-mini" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete-branch-cat&categorycode=*&branch=[% current_branch %]" onclick="return confirm(MSG_CONFIRM_UNSET);"><i class="fa fa-undo"></i> Unset</a> > </td> > </tr> > </table> >@@ -489,7 +492,7 @@ for="tobranch"><strong>Clone these rules to:</strong></label> <input type="hidde > </td> > > <td class="actions"> >- <a class="btn btn-mini" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete-branch-cat&categorycode=[% branch_cat_rule_loo.categorycode %]&branch=[% current_branch %]"><i class="fa fa-trash"></i> Delete</a> >+ <a class="btn btn-mini" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete-branch-cat&categorycode=[% branch_cat_rule_loo.categorycode %]&branch=[% current_branch %]" onclick="return confirm(MSG_CONFIRM_DELETE);"><i class="fa fa-trash"></i> Delete</a> > </td> > </tr> > [% END %] >@@ -569,7 +572,7 @@ for="tobranch"><strong>Clone these rules to:</strong></label> <input type="hidde > [% END %] > </td> > <td class="actions"> >- <a class="btn btn-mini" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete-branch-item&itemtype=[% branch_item_rule_loo.itemtype %]&branch=[% current_branch %]"><i class="fa fa-trash"></i> Delete</a> >+ <a class="btn btn-mini" href="/cgi-bin/koha/admin/smart-rules.pl?op=delete-branch-item&itemtype=[% branch_item_rule_loo.itemtype %]&branch=[% current_branch %]" onclick="return confirm(MSG_CONFIRM_DELETE);"><i class="fa fa-trash"></i> Delete</a> > </td> > </tr> > [% END %] >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16268
:
50253
|
50301
|
50502
|
50602
|
50670
|
50706
|
50727