Bugzilla – Attachment 50386 Details for
Bug 15682
Merging records from cataloguing search only allows to merge 2 records
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15682 - Merging records from cataloguing search only allows to merge 2 records
PASSED-QA-Bug-15682---Merging-records-from-catalog.patch (text/plain), 2.04 KB, created by
Katrin Fischer
on 2016-04-19 06:27:08 UTC
(
hide
)
Description:
[PASSED QA] Bug 15682 - Merging records from cataloguing search only allows to merge 2 records
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-04-19 06:27:08 UTC
Size:
2.04 KB
patch
obsolete
>From 159f17a1e1b65bbd7b3636e168c99ab7ffdda0a4 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 28 Mar 2016 20:01:30 +0000 >Subject: [PATCH] [PASSED QA] Bug 15682 - Merging records from cataloguing > search only allows to merge 2 records > >To test: >1 - Perform a cataloging search >2 - Attempt to merge 0 results - should fail >3 - Attempt to merge 1 resutls - should fail >4 - Attempt to merge 2 results - should succeed >5 - Attempt to merge 3 results - should succeed >6 - Test any other amount of records and if more than 1 it should >succeed > >**Note: On shelves.pl you can merge a single record. I think that is >incorrect so made this only work for 2. Will add a followup to fix >shelves.pl > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.z> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >index ca379c2..c189583 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >@@ -64,11 +64,15 @@ > */ > function MergeItems() { > var checkboxes = $("input:checkbox:checked"); >- var nbCheckbox = checkboxes.length; >- if (nbCheckbox != 2) { >- alert(_("Two records must be selected for merging.")); >+ if (checkboxes.length < 2) { >+ alert(_("At least two records must be selected for merging.")); > } else { >- location.href='/cgi-bin/koha/cataloguing/merge.pl?biblionumber=' + checkboxes[0].value + '&biblionumber=' + checkboxes[1].value; >+ var params = []; >+ $(checkboxes).each(function() { >+ params.push('biblionumber=' + $(this).val()); >+ }); >+ var url = '/cgi-bin/koha/cataloguing/merge.pl?' + params.join('&'); >+ location.href = url; > } > return false; > } >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15682
:
49605
|
49606
|
50371
|
50372
| 50386 |
50387