Bugzilla – Attachment 50991 Details for
Bug 16389
Reports row limit should change upon option selection
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16389: Reports row limit should change upon option selection
Bug-16389-Reports-row-limit-should-change-upon-opt.patch (text/plain), 2.35 KB, created by
Marc Véron
on 2016-04-29 13:18:24 UTC
(
hide
)
Description:
Bug 16389: Reports row limit should change upon option selection
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2016-04-29 13:18:24 UTC
Size:
2.35 KB
patch
obsolete
>From 3452c6d0eeb05854c342b6b6442e92d4bcc5f1fc Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Fri, 29 Apr 2016 03:00:28 +0000 >Subject: [PATCH] Bug 16389: Reports row limit should change upon option > selection >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To test: >1) Run a report >2) Confirm there is no 'Update' button next to the 'Rows per page:' dropdown >3) Change the limit (i.e. to 10) >4) Confirm the page updates itself > >Sponsored-by: Catalyst IT > >Signed-off-by: Marc Véron <veron@veron.ch> >--- > .../prog/en/modules/reports/guided_reports_start.tt | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index bbc539b..15ecf78 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -67,6 +67,9 @@ function load_group_subgroups () { > } > > $(document).ready(function(){ >+ $('#limit').change(function() { >+ $('#limitselect').submit(); >+ }); > > $(".goback").on("click",function(e){ > e.preventDefault(); >@@ -807,7 +810,7 @@ canned reports and writing custom SQL reports.</p> > [% IF ( unlimited_total ) %]<p>Total number of rows matching the (unlimited) query is [% unlimited_total %].</p>[% END %] > <pre id="sql_output">[% sql |html %]</pre> > >-<form action="/cgi-bin/koha/reports/guided_reports.pl" method="get"> >+<form action="/cgi-bin/koha/reports/guided_reports.pl" method="get" id="limitselect"> > <input type="hidden" name="phase" value="Run this report"/> > <input type="hidden" name="reports" value="[% report_id %]"/> > >@@ -816,7 +819,7 @@ canned reports and writing custom SQL reports.</p> > [% END %] > > <label for="limit">Rows per page: </label> >- <select name="limit"> >+ <select name="limit" id="limit"> > [% limits = [ 10, 20, 50, 100, 200, 300, 400, 500, 1000 ] %] > [% FOREACH l IN limits %] > [% IF l == limit %] >@@ -826,8 +829,6 @@ canned reports and writing custom SQL reports.</p> > [% END %] > [% END %] > </select> >- >- <input type="submit" value="Update" /> > </form> > > <div class="pages">[% pagination_bar %]</div> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16389
:
50978
|
50991
|
51021