Bugzilla – Attachment 51047 Details for
Bug 16397
Unable to delete audio alerts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16397 - Unable to delete audio alerts
Bug-16397---Unable-to-delete-audio-alerts.patch (text/plain), 1.79 KB, created by
Marc Véron
on 2016-04-30 09:06:51 UTC
(
hide
)
Description:
Bug 16397 - Unable to delete audio alerts
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2016-04-30 09:06:51 UTC
Size:
1.79 KB
patch
obsolete
>From 0a2d35bff79c5930996eee8017aaf8da8b4d2ccf Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 29 Apr 2016 12:29:01 -0400 >Subject: [PATCH] Bug 16397 - Unable to delete audio alerts >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch corrects a JavaScript error which has arisen due to the >jQuery upgrade. This should have been included in Bug 16321. > >To test, apply the patch and go to Administration -> Audio alerts. > >- In the list of existing audio alerts, check one or more checkboxes. > The "Delete selected" button should become enabled. >- Uncheck all checkboxes and check that the "Delete selected" button is > now disabled. >- Confirm that deletions are completed correctly. > >Signed-off-by: Marc Véron <veron@veron.ch> >--- > koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js b/koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js >index 154c33a..f16f050 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js >@@ -2,7 +2,7 @@ $( document ).ready(function() { > var checkboxes = $("#delete-alert-form input[type='checkbox']"); > var checkedcheckboxes = 0; > checkboxes.on("change",function(){ >- if( $(checkboxes+":checked").length > 0){ >+ if( $("#delete-alert-form").find("input:checked").length > 0){ > checkedcheckboxes = 1; > $("#delete-alerts").removeClass("disabled"); > } else { >@@ -86,4 +86,4 @@ function EditAlert( elt, id, precedence, selector, sound ) { > $("#sound").val(sound); > $("#koha-sounds").val(sound); > enablePlayButton(sound,$('#play-sound')); >-} >\ No newline at end of file >+} >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16397
:
51023
|
51047
|
51068