Bugzilla – Attachment 51147 Details for
Bug 16426
Import borrowers tool warns for blank and/or existing userids
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16426: Add tests for ModMember - do not update userid
Bug-16426-Add-tests-for-ModMember---do-not-update-.patch (text/plain), 1.87 KB, created by
Nick Clemens
on 2016-05-03 14:59:33 UTC
(
hide
)
Description:
Bug 16426: Add tests for ModMember - do not update userid
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2016-05-03 14:59:33 UTC
Size:
1.87 KB
patch
obsolete
>From 9a251dd9623715d03263886c88937212509548da Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 3 May 2016 08:58:26 +0100 >Subject: [PATCH] Bug 16426: Add tests for ModMember - do not update userid > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > t/db_dependent/Members.t | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Members.t b/t/db_dependent/Members.t >index e369128..3290fe1 100755 >--- a/t/db_dependent/Members.t >+++ b/t/db_dependent/Members.t >@@ -17,7 +17,7 @@ > > use Modern::Perl; > >-use Test::More tests => 76; >+use Test::More tests => 77; > use Test::MockModule; > use Data::Dumper; > use C4::Context; >@@ -231,6 +231,19 @@ $borrowernumber = AddMember( %data ); > $borrower = GetMember( borrowernumber => $borrowernumber ); > is( $borrower->{userid}, $data{userid}, 'AddMember should insert the given userid' ); > >+subtest 'ModMember should not update userid if not true' => sub { >+ plan tests => 3; >+ ModMember( borrowernumber => $borrowernumber, firstname => 'Tomas', userid => '' ); >+ $borrower = GetMember( borrowernumber => $borrowernumber ); >+ is ( $borrower->{userid}, $data{userid}, 'ModMember should not update the userid with an empty string' ); >+ ModMember( borrowernumber => $borrowernumber, firstname => 'Tomas', userid => 0 ); >+ $borrower = GetMember( borrowernumber => $borrowernumber ); >+ is ( $borrower->{userid}, $data{userid}, 'ModMember should not update the userid with an 0'); >+ ModMember( borrowernumber => $borrowernumber, firstname => 'Tomas', userid => undef ); >+ $borrower = GetMember( borrowernumber => $borrowernumber ); >+ is ( $borrower->{userid}, $data{userid}, 'ModMember should not update the userid with an undefined value'); >+}; >+ > #Regression tests for bug 10612 > my $library3 = $builder->build({ > source => 'Branch', >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16426
:
51123
|
51124
|
51147
|
51148
|
51274
|
51275
|
51276