From e2695e32b4d763a0ec32a41efc6e5cb3d3d55828 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 4 May 2016 20:08:53 +0100 Subject: [PATCH] Bug 16443: Make C4::Members::Statistics plack safe If the prefs is updated, the fields won't be. To make sure we already fetch updated values, we should remove the package variable and define it in the subroutine. There is not test plan, just make sure the changes are consistent. --- C4/Members/Statistics.pm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/C4/Members/Statistics.pm b/C4/Members/Statistics.pm index b8b3a0f..23771c1 100644 --- a/C4/Members/Statistics.pm +++ b/C4/Members/Statistics.pm @@ -40,10 +40,6 @@ BEGIN { ); } - -our $fields = get_fields(); - - =head2 get_fields Get fields form syspref 'StatisticsFields' Returns list of valid fields, defaults to 'location|itype|ccode' @@ -79,6 +75,7 @@ sub get_fields { sub construct_query { my $count = shift; my $subquery = shift; + my $fields = get_fields(); my @select_fields = split '\|', $fields; my $query = "SELECT COUNT(*) as count_$count,"; $query .= join ',', @select_fields; -- 2.7.0