@@ -, +, @@ - On master, run: $ prove t/t/00-testcritic.t - Apply the patch - Run: $ prove t/t/00-testcritic.t - Sign off :-D --- Koha/Authority.pm | 2 +- catalogue/search.pl | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) --- a/Koha/Authority.pm +++ a/Koha/Authority.pm @@ -64,7 +64,7 @@ sub get_all_authorities_iterator { { columns => [qw/ authid authtypecode marcxml /] } ); my $next_func = sub { my $row = $rs->next(); - return undef if !$row; + return if !$row; my $authid = $row->authid; my $authtypecode = $row->authtypecode; my $marcxml = $row->marcxml; --- a/catalogue/search.pl +++ a/catalogue/search.pl @@ -472,8 +472,6 @@ my $builder = Koha::SearchEngine::QueryBuilder->new( my $searcher = Koha::SearchEngine::Search->new( { index => $Koha::SearchEngine::BIBLIOS_INDEX } ); -my @results; - ## I. BUILD THE QUERY ( $error, $query, $simple_query, $query_cgi, --