From 574556e2863dd5012f0cc99ab043c12b47dfa4c9 Mon Sep 17 00:00:00 2001
From: Tomas Cohen Arazi <tomascohen@theke.io>
Date: Thu, 5 May 2016 11:19:50 -0300
Subject: [PATCH] [PASSED QA] Bug 16448: Fix perlcritic errors introduced by
 12478

Bug 12478 introduced two perlcritic errors. This patch fixes them.

To test:
- On master, run:
  $ prove t/00-testcritic.t
=> FAIL: catalogue/search.pl and Koha/Authority.pm fail the critic tests.
- Apply the patch
- Run:
  $ prove t/00-testcritic.t
=> SUCCESS: All happy
- Sign off :-D

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
All test successful. Needs $ export TEST_QA=1

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
---
 Koha/Authority.pm   | 2 +-
 catalogue/search.pl | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/Koha/Authority.pm b/Koha/Authority.pm
index 9de8be5..fec63d3 100644
--- a/Koha/Authority.pm
+++ b/Koha/Authority.pm
@@ -64,7 +64,7 @@ sub get_all_authorities_iterator {
         { columns => [qw/ authid authtypecode marcxml /] } );
     my $next_func = sub {
         my $row = $rs->next();
-        return undef if !$row;
+        return if !$row;
         my $authid       = $row->authid;
         my $authtypecode = $row->authtypecode;
         my $marcxml      = $row->marcxml;
diff --git a/catalogue/search.pl b/catalogue/search.pl
index dd73277..c70efb0 100755
--- a/catalogue/search.pl
+++ b/catalogue/search.pl
@@ -472,8 +472,6 @@ my $builder = Koha::SearchEngine::QueryBuilder->new(
 my $searcher = Koha::SearchEngine::Search->new(
     { index => $Koha::SearchEngine::BIBLIOS_INDEX } );
 
-my @results;
-
 ## I. BUILD THE QUERY
 (
     $error,             $query, $simple_query, $query_cgi,
-- 
1.9.1