Bugzilla – Attachment 51298 Details for
Bug 16469
Remove the use of "onclick" from some catalog pages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16469 - Remove the use of "onclick" from some catalog pages
Bug-16469---Remove-the-use-of-onclick-from-some-ca.patch (text/plain), 4.27 KB, created by
Owen Leonard
on 2016-05-06 16:47:29 UTC
(
hide
)
Description:
Bug 16469 - Remove the use of "onclick" from some catalog pages
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2016-05-06 16:47:29 UTC
Size:
4.27 KB
patch
obsolete
>From 2019330ec773555d43d7e602607ddef07c2ba3eb Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 6 May 2016 11:40:00 -0400 >Subject: [PATCH] Bug 16469 - Remove the use of "onclick" from some catalog > pages >Content-Type: text/plain; charset="utf-8" > >This patch removes the use of "onclick" attributes from two >catalog-related templates: The local cover image viewer and the search >results page. Events are now defined in JavaScript. > >To test: > >On the search results page: > >- Perform a catalog search which will return multiple results. >- On the search results page, confirm that the "Select all" and "Clear > all" links at the top of the results table work correctly. > >In the local cover image viewer: > >- The LocalCoverImages and AllowMultipleCovers system preferences must > enabled, and at least one catalog record must have at least two local > cover images attached. >- Locate that record in the catalog and view the detail page for it. >- Click the cover image in the "Images" tab to go to the image viewer > page. >- Clicking each local cover image thumnail should correctly display the > larger version of each image. > >https://bugs.koha-community.org/show_bug.cgi?id=16249 >--- > .../intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt | 7 ++++++- > .../intranet-tmpl/prog/en/modules/catalogue/results.tt | 13 ++++++++++--- > 2 files changed, 16 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt >index 60674d0..7e6fffd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt >@@ -7,6 +7,11 @@ > > $(document).ready(function(){ > showCover([% imagenumber %]); >+ $(".show_cover").on("click",function(e){ >+ e.preventDefault(); >+ var coverimg = $(this).data("coverimg"); >+ showCover(coverimg); >+ }); > }); > > function showCover(img) { >@@ -75,7 +80,7 @@ img.thumbnail { > > [% FOREACH img IN images %] > [% IF img %] >- <a href="/cgi-bin/koha/catalogue/imageviewer.pl?biblionumber=[% biblionumber %]&imagenumber=[% img %]" onclick="showCover([% img %]); return false;"> >+ <a class="show_cover" data-coverimg="[% img %]" href="/cgi-bin/koha/catalogue/imageviewer.pl?biblionumber=[% biblionumber %]&imagenumber=[% img %]"> > [% IF ( imagenumber == img ) %] > <img class="thumbnail selected" id="[% img %]" src="/cgi-bin/koha/catalogue/image.pl?imagenumber=[% img %]&thumbnail=1" alt="Thumbnail" /> > [% ELSE %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 6e71a41..b1ed175 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -183,7 +183,14 @@ $('#sort_by').change(function() { > [% END %] > > [% IF LocalCoverImages %]KOHA.LocalCover.LoadResultsCovers();[% END %] >- >+ $("#select_all").on("click",function(e){ >+ e.preventDefault(); >+ selectAll(); >+ }); >+ $("#clear_all").on("click",function(e){ >+ e.preventDefault(); >+ clearAll(); >+ }); > }); > > >@@ -338,9 +345,9 @@ var holdForPatron = function () { > [% total %] result(s) found [% IF ( query_desc ) %]for <span style="font-weight: bold;">'[% query_desc |html %]'</span>[% END %][% IF limit_desc %] with limit(s): <span style="font-weight: bold;">'[% limit_desc | html %]'</span>[% END %][% IF ( LibraryName ) %] in [% LibraryName %] Catalog[% END %].<br /> > </h3> > <div id="selection_ops" class="cartlist" style="display:none"> >- <a href="#" onclick="selectAll(); return false;">Select all</a> >+ <a href="#" id="select_all">Select all</a> > | >- <a href="#" onclick="clearAll(); return false;">Clear all</a> >+ <a href="#" id="clear_all">Clear all</a> > | > <a href="#" class="highlight_toggle" id="highlight_toggle_off">Unhighlight</a> > <a href="#" class="highlight_toggle" id="highlight_toggle_on">Highlight</a> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16469
:
51298
|
51978
|
52643